Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi cv ak displays content view environments information #16991

Merged
merged 6 commits into from
Nov 26, 2024
Merged

multi cv ak displays content view environments information #16991

merged 6 commits into from
Nov 26, 2024

Conversation

vijaysawant
Copy link
Contributor

Problem Statement

Automation coverage for SAT-27863
Adds support for multi environment activation keys.

Solution

new test case "test_positive_multi_cv_info"

Related Issues

No

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/cli/test_activationkey.py -k 'test_positive_multi_cv_info'

@vijaysawant vijaysawant added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Nov 22, 2024
@vijaysawant vijaysawant requested a review from a team as a code owner November 22, 2024 17:32
@vijaysawant
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_activationkey.py -k 'test_positive_multi_cv_info'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9451
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_activationkey.py -k test_positive_multi_cv_info --external-logging
Test Result : ========= 1 passed, 144 deselected, 157 warnings in 1211.36s (0:20:11) =========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 22, 2024
LadislavVasina1
LadislavVasina1 requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@LadislavVasina1 LadislavVasina1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment suggesting a little change in the test's code structure, could you please try to do it via the suggested approach? Otherwise good job @vijaysawant!

P.S.
I think that the structure I suggested should work right a way, but better try it yourself.

vsedmik
vsedmik requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small change request. It is non-blocking but nice to have.

tests/foreman/cli/test_activationkey.py Outdated Show resolved Hide resolved
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 25, 2024
@vijaysawant
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_activationkey.py -k 'test_positive_multi_cv_info'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9461
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_activationkey.py -k test_positive_multi_cv_info --external-logging
Test Result : ========= 1 passed, 144 deselected, 157 warnings in 1089.42s (0:18:09) =========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 26, 2024
@LadislavVasina1
Copy link
Contributor

@vijaysawant please apply vsedmik and mine suggestion, after that it will be easy ACK from me, GJ

@vijaysawant
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_activationkey.py -k 'test_positive_multi_cv_info'

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 26, 2024
vsedmik
vsedmik approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the comments!

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9462
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_activationkey.py -k test_positive_multi_cv_info --external-logging
Test Result : ========= 1 passed, 144 deselected, 157 warnings in 1118.70s (0:18:38) =========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 26, 2024
@vsedmik vsedmik merged commit 668bf8b into SatelliteQE:master Nov 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColeHiggins2 ColeHiggins2 ColeHiggins2 left review comments

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

@vsedmik vsedmik vsedmik approved these changes

@jeremylenz jeremylenz jeremylenz approved these changes

Assignees

@vijaysawant vijaysawant

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vijaysawant @Satellite-QE @LadislavVasina1 @jeremylenz @ColeHiggins2 @vsedmik