CV Publish #948
CV Publish #948
Conversation
sambible
added
CherryPick
sambible
force-pushed
the
cv-ui-simplepublish
branch
from
2e91d5a
to
91d4ff5
Compare
sambible
force-pushed
the
cv-ui-simplepublish
branch
from
91d4ff5
to
4e365ef
Compare
airgun/entities/contentview_new.py
Outdated
|
|
||
| from airgun.entities.base import BaseEntity | ||
| from airgun.navigation import NavigateStep | ||
| from airgun.navigation import navigator | ||
| from airgun.utils import retry_navigation | ||
| from airgun.views.contentview_new import NewContentViewCreateView | ||
| from airgun.views.contentview_new import NewContentViewTableView | ||
| from airgun.views.contentview_new import NewContentViewEditView |
There was a problem hiding this comment.
If this is only Content View and the older one is absolute, I think we can rename this to ContentView instead of adding New prefix
airgun/widgets.py
Outdated
| def is_completed(self): | ||
| """Boolean value whether progress bar is finished or not""" | ||
| if not self.is_active and self.progress == '100%': | ||
| return True | ||
| return False |
There was a problem hiding this comment.
There is no need to write this as this is same as the parent method, object will have the reference for this
airgun/widgets.py
Outdated
| def __init__(self, parent, locator=None, logger=None): | ||
| """Provide common progress bar locator if it wasn't specified.""" | ||
| Widget.__init__(self, parent, logger=logger) | ||
| if not locator: | ||
| locator = self.PROGRESSBAR | ||
| self.locator = locator |
There was a problem hiding this comment.
This is also not needed as it is same as parent class
|
@sambible I provided some suggestions mostly easy ones. Please let me know your thoughts |
|
@sambible I see some conflicts here can you please resolve them |
…v-ui-simplepublish
|
@omkarkhatavkar merged everything proper and fixed issues |
|
Are you able to run the new code formatter locally? Should save you from some nasty merge conflicts. |
|
@omkarkhatavkar @mstrlc ran ruff on it, hopefully CI quality should be happy now. |
sambible
force-pushed
the
cv-ui-simplepublish
branch
from
0aebe8c
to
73529bc
Compare
|
@sambible can you please fix the CI code quality error |
|
Alright, took some massaging, but it's ready to merge @omkarkhatavkar |
|
@sambible I need one more ack to merge this. |
|
@lhellebr you had a lot of good comments over in my newer PR, can I get you to review the same changes over here? We can get this merged then, and it should shrink down my blank page PR :) |
|
(that PR was based off this, since I needed parts of this PR to make the test work, but it hadn't been merged yet) |
sambible
force-pushed
the
cv-ui-simplepublish
branch
from
09f7c60
to
6ab27e3
Compare
…v-ui-simplepublish
sambible
force-pushed
the
cv-ui-simplepublish
branch
from
6ab27e3
to
5fe220f
Compare
Recut some stuff in my previous PR, this should constitute a minimally viable Publish workflow.
There is some additional stuff, like an expansive Edit view, but that's required for checking the Versions Tab.
Sister Robottelo PR ( much easier to review, hah ) :SatelliteQE/robottelo#12328