Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new project code standards #938

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

JacobCallahan
Copy link
Member

This change adds Ruff as the new linter and loosens Black's formatting as well.
Due to this change, we can drop flake8 and old pre-commit hooks.

@JacobCallahan
Copy link
Member Author

JacobCallahan commented Aug 23, 2023

The pre-commit check will fail on the below error until we have a determination on what the actual contents of the method should be.

airgun/entities/host_new.py:770:9: T201 `print` found

We also have a couple of bare exceptions to make a determination on.

airgun/browser.py Show resolved Hide resolved
airgun/entities/location.py Show resolved Hide resolved
airgun/entities/virtwho_configure.py Show resolved Hide resolved
@omkarkhatavkar
Copy link

trigger: test-robottelo
pytest: --component Puppet tests/foreman/ui

@JacobCallahan JacobCallahan added 6.12.z CherryPick PR needs CherryPick to previous branches 6.11.z 6.13.z 6.14.z labels Aug 30, 2023
@JacobCallahan JacobCallahan marked this pull request as ready for review August 30, 2023 13:53
@omkarkhatavkar
Copy link

trigger: test-robottelo
pytest: --component Puppet tests/foreman/ui

@JacobCallahan
Copy link
Member Author

trigger: test-robottelo
pytest: --component Puppet tests/foreman/ui

Comment on lines 769 to 771
def step(self, *args, **kwargs):
print(self.parent.rolesListTable)
# print(self.parent.rolesListTable) TODO @sbible - Determine what should be done here
pass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep the TODO and logger.debug(self.parent.rolesListTable).
I'm not sure what @sambible wanted to achieve here though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can just remove this, iirc I left that more for myself when working on this file, and never remembered to remove it.

pyproject.toml Outdated Show resolved Hide resolved
@JacobCallahan
Copy link
Member Author

trigger: test-robottelo
pytest: --component Puppet tests/foreman/ui

Comment on lines 769 to 771
def step(self, *args, **kwargs):
print(self.parent.rolesListTable)
# print(self.parent.rolesListTable) TODO @sbible - Determine what should be done here
pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can just remove this, iirc I left that more for myself when working on this file, and never remembered to remove it.

This change adds Ruff as the new linter and loosens Black's formatting
as well.
Due to this change, we can drop flake8 and old pre-commit hooks.
@JacobCallahan JacobCallahan merged commit 5b7aa9d into SatelliteQE:master Sep 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.11.z 6.12.z 6.13.z 6.14.z CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants