-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new project code standards #938
Conversation
The pre-commit check will fail on the below error until we have a determination on what the actual contents of the method should be.
We also have a couple of bare exceptions to make a determination on. |
trigger: test-robottelo |
trigger: test-robottelo |
e0ffd16
to
502453d
Compare
trigger: test-robottelo |
airgun/entities/host_new.py
Outdated
def step(self, *args, **kwargs): | ||
print(self.parent.rolesListTable) | ||
# print(self.parent.rolesListTable) TODO @sbible - Determine what should be done here | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep the TODO and logger.debug(self.parent.rolesListTable)
.
I'm not sure what @sambible wanted to achieve here though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can just remove this, iirc I left that more for myself when working on this file, and never remembered to remove it.
trigger: test-robottelo |
airgun/entities/host_new.py
Outdated
def step(self, *args, **kwargs): | ||
print(self.parent.rolesListTable) | ||
# print(self.parent.rolesListTable) TODO @sbible - Determine what should be done here | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can just remove this, iirc I left that more for myself when working on this file, and never remembered to remove it.
This change adds Ruff as the new linter and loosens Black's formatting as well. Due to this change, we can drop flake8 and old pre-commit hooks.
502453d
to
f0ab9ca
Compare
This change adds Ruff as the new linter and loosens Black's formatting as well.
Due to this change, we can drop flake8 and old pre-commit hooks.