Skip to content
This repository has been archived by the owner on Jul 18, 2023. It is now read-only.

API access from v2 to v3, migration from centralci to upshift #56

Merged
merged 2 commits into from
Apr 2, 2019

Conversation

tstrych
Copy link
Contributor

@tstrych tstrych commented Mar 28, 2019

No description provided.

Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, great to see this PR! 🎉

I tested that listing images, instances, flavours and booting, shapshoting and deleting instances works as expected. 👍
I hit the error when I was trying to upload a new SSH key to the OpenStack. But I assume that it won't affect the general usability.
5minute --debug key ~/.ssh/id_rsa2.pub

File "/usr/lib/python3.7/site-packages/vminute/vminute.py", line 171, in wrapper
    return func(*args, **kwargs)
  File "/usr/lib/python3.7/site-packages/vminute/vminute.py", line 409, in __upload_key
    self.nova.keypairs.create(self.key_name, fd.read())
  File "/usr/lib/python3.7/site-packages/novaclient/api_versions.py", line 393, in substitution
    return methods[-1].func(obj, *args, **kwargs)
  File "/usr/lib/python3.7/site-packages/novaclient/v2/keypairs.py", line 100, in create
    return self._create('/%s' % self.keypair_prefix, body, 'keypair')
  File "/usr/lib/python3.7/site-packages/novaclient/base.py", line 366, in _create
    resp, body = self.api.client.post(url, body=body)
  File "/home/ogajduse/.local/lib/python3.7/site-packages/keystoneauth1/adapter.py", line 357, in post
    return self.request(url, 'POST', **kwargs)
  File "/usr/lib/python3.7/site-packages/novaclient/client.py", line 83, in request
    raise exceptions.from_response(resp, body, url, method)


The problem with public key upload.

vminute/vminute.py Show resolved Hide resolved
@tstrych
Copy link
Contributor Author

tstrych commented Mar 29, 2019

@ogajduse working on ssh-keys

@tstrych
Copy link
Contributor Author

tstrych commented Mar 29, 2019

I do not use list comprehension, ( it would be long line ) I think this is clean enough.

Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, I haven't noticed that this was present even before changes in this PR.
Works perfectly!

5minute --debug key ~/.ssh/id_rsa2.pub

You already have keypair with name ogajduse

@tstrych tstrych merged commit 9431432 into SatelliteQE:master Apr 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants