Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raygun: Implement unread status #349

Open
dariusc93 opened this issue Oct 27, 2023 · 0 comments
Open

raygun: Implement unread status #349

dariusc93 opened this issue Oct 27, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request improvement Improve on existing feature P-Normal Normal Priority

Comments

@dariusc93
Copy link
Contributor

In the current implementation, there is no way to tell if a message has been read or seen by a user. Instead, this would likely rely on more additional logic in any frontend implementation. On top of that, no event is emitted to the conversation when the message is read to change the status of the message itself.

Here, I believe that it would be better to add functionality to allow RayGun to inform the user of any unread messages, either by adding a option to MessageOption so RayGun::get_messages would list unread messages. We could also add a option to only count unread messages with RayGun::get_message_count to determine any messages that havent been read by the local node, while:

  1. Adding an argument to to RayGun::get_messages and RayGun::get_message to mark any messages fetched as read; or
  2. Add a new function called RayGun::read_message, which would mark a set of messages as read.

An event can be emitted to both the local node as well as the participant in the conversation about the message being read for direct messages. For group messages, this could possibly be ignored, although we could still emit an event about the message being read when it comes in, but may not be desirable in such a setting.

In addition, we can add a new status to MessageStatus, possibly called MessageStatus::Read to indicate if any successfully sent or receive message have been read, and possibly provide a list of those have read it.

Note:

  • If the recipient read the message, it cannot be unread.
  • If a list of peers is supplied to MessageStatus::Read, it will only list those who are apart of the group conversation, if we allow for the event be emitted.
@dariusc93 dariusc93 added enhancement New feature or request improvement Improve on existing feature P-Low Low Priority labels Oct 27, 2023
@dariusc93 dariusc93 self-assigned this Oct 27, 2023
@tooshel tooshel added this to Uplink Nov 10, 2023
@github-project-automation github-project-automation bot moved this to Backlog in Uplink Nov 10, 2023
@tooshel tooshel added this to the Offline Support milestone Nov 10, 2023
@dariusc93 dariusc93 removed this from Uplink Dec 16, 2023
@dariusc93 dariusc93 removed this from the Offline Support milestone Jun 25, 2024
@dariusc93 dariusc93 added P-Normal Normal Priority and removed P-Low Low Priority labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request improvement Improve on existing feature P-Normal Normal Priority
Projects
None yet
Development

No branches or pull requests

2 participants