-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[record-hessian] Introduce RecordHessian. #14295
base: master
Are you sure you want to change the base?
Conversation
8591d2e
to
e416acd
Compare
Your current commit title/message is
which doesn't seem to express current changes. |
@seanshpark I tried splitting the code into smaller parts, but nncc-common does not allow me to compile if there are unused variables or unimplemented functions. So, could you review my code in this form? |
you can solve this. |
This commit introduce record hessian. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Delete unused variables and lines. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Apply feed back, make comment more precise. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Add maybe_unused mark to avoid compile error. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Fix formatting error due to comments. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Fix formatting error with nnas_format. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
you have useless header file and uncalled methods. |
I split the code. That method will be implemented in later PR! //namespace record_hessian |
Remove useless headers and add comments ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
This introduces a part of RecordHessian.
ONE-DCO-1.0-Signed-off-by: Banseok Lee [email protected]
Related Issue : #13480
Draft PR: #13585