Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[토너먼트] 토너먼트 인트로 화면 퍼블리싱 및 랜더링 #67

Merged
merged 11 commits into from
Jan 11, 2024
Merged

[토너먼트] 토너먼트 인트로 화면 퍼블리싱 및 랜더링 #67

merged 11 commits into from
Jan 11, 2024

Conversation

imeureka
Copy link
Member

이슈 넘버

구현 사항

  • 공통 컴포넌트 활용해서 퍼블리싱 완료했습니다.
  • 네이밍 오타 수정했습니다.
  • 스타일 코드 분리했습니다.
  • 시작하기 버튼 누르면 라운드 화면 랜더링 구현했습니다.

Need Review

  • ~ 부분 이렇게 구현했어요, 피드백 부탁해요!

📸 스크린샷

2024-01-10.2.32.38.mov

Reference

@imeureka imeureka added feat💡 기능 구현 style🎨 작은 사항 수정 및 style 코드 작성 토너먼트 🏆 토너먼트 페이지 labels Jan 10, 2024
@imeureka imeureka self-assigned this Jan 10, 2024
@github-actions GitHub Actions
Copy link

PR Preview Action v1.4.6
🚀 Deployed preview to https://SWEET-DEVELOPERS.github.io/sweet-client/pr-preview/pr-67/
on branch gh-pages at 2024-01-11 04:22 UTC

hoeun0723
hoeun0723 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@hoeun0723 hoeun0723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔하고 이슈 단위로 구현해서 문제 없는거 같습니다 ㅎㅎㅎ 화면에서 깨지는거나 비율 같은거를 직접 볼 수 있었음 좋겠는데, 올려주신 영상으로는 문제 없는거 같아 approve 합니다 !! :)

@imeureka imeureka added the fix 🛠️ Something isn't working label Jan 11, 2024
@imeureka imeureka merged commit 1e97d05 into develop Jan 11, 2024
1 check passed
@imeureka imeureka deleted the refactor/#64-tournament-intro branch February 2, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ExceptAnyone ExceptAnyone ExceptAnyone approved these changes

@urjimyu urjimyu urjimyu approved these changes

@hoeun0723 hoeun0723 hoeun0723 approved these changes

Assignees

@imeureka imeureka

Labels
feat💡 기능 구현 fix 🛠️ Something isn't working style🎨 작은 사항 수정 및 style 코드 작성 토너먼트 🏆 토너먼트 페이지
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[토너먼트] 인트로 화면 리팩토링
4 participants
@imeureka @hoeun0723 @urjimyu @ExceptAnyone