[공통컴포넌트] Button 10가지 구현 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
January 7, 2024 01:50
imeureka
approved these changes
Jan 10, 2024
| import styled from 'styled-components'; | ||
|
|
||
| export const Wrapper = styled.button` | ||
| ${({ theme: { mixin } }) => mixin.inlineFlexBox({ align: 'center', justify: 'center' })} |
There was a problem hiding this comment.
mixin 사용 짱짱 저는 저번에 코드리뷰 봤을 때 베이직한 공통 틀이 아니면 불필요한 리소스를 들이는 것보다 나을 것 같다는 의견을 봐서 공유해드립니다! 지금은 우린 써도 좋은 거 같아요! 참고로 공유해봅니다!
There was a problem hiding this comment.
해당 코드 리뷰는 아마 뒤늦게 정해진 부분에 대해서 불필요한 리소스가 든다고 했던게 아닌가 싶어요 !!! (또 다시 분류 해야하는 리소스를 의미하는 것이라고 생각되었습니다 !)
mixin 부분을 미리 의논해두었고, 반복 되어지는 간단한 부분들을 props로 조정할 수도 있도록 초반에 만들어 두었으니 저희는 지속해서 사용해도 될 거 같습니다 ;)
좋은 리프레쉬 감사해요 !!
There was a problem hiding this comment.
저도 덕분에 mixin 사용 목적에 대해 다시 고민해보는 좋은 기회가 되었어요! 감사합니다~!
| return ( | ||
| <S.Wrapper disabled={disabled} onClick={onClick}> | ||
| {children} | ||
| <IcRight style={{ width: '24px', height: '24px' }} /> |
There was a problem hiding this comment.
세상에 빠르게 수정하도록 하겠습니다 !!!
ExceptAnyone
approved these changes
Jan 10, 2024
added 2 commits
January 10, 2024 12:41
urjimyu
approved these changes
Jan 10, 2024
| @@ -2,7 +2,7 @@ import type { SVGProps } from 'react'; | |||
| const SvgIcEdit2 = (props: SVGProps<SVGSVGElement>) => ( | |||
| <svg xmlns='http://www.w3.org/2000/svg' fill='none' viewBox='0 0 24 24' {...props}> | |||
| <path | |||
| stroke='#000' | |||
| stroke='currentColor' | |||
| import styled from 'styled-components'; | ||
|
|
||
| export const Wrapper = styled.button` | ||
| ${({ theme: { mixin } }) => mixin.inlineFlexBox({ align: 'center', justify: 'center' })} |
There was a problem hiding this comment.
저도 덕분에 mixin 사용 목적에 대해 다시 고민해보는 좋은 기회가 되었어요! 감사합니다~!
| type BtnChangeProps = ButtonHTMLAttributes<HTMLButtonElement> & { | ||
| disabled?: boolean; | ||
| children: React.ReactNode; | ||
| onClick?: () => void; |
|
|
머지 하겠습니다 !! : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 사항
10가지 종류의 button 구현을 했습니다.
Need Review
특별히 받아야 하는 값이 있는 컴포넌트의 경우는 옵셔널 적용을 하지 않았습니다. interface를 잘 확인하고 사용해주세요!