Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UYUNI MASTER PRV - rename module names and remove configurations to use cucumber testsuite default values and convert to podman #1466

Merged

Conversation

maximenoel8
Copy link
Contributor

@maximenoel8 maximenoel8 commented Nov 24, 2024

What does this PR do?

  • Modules components changes:

    • rename module names using _ to separate words and make sure module names are compatible with cucumber testsuite module.
    • remove name parameter to use default cucumber testsuite names. This will automatically use the new hostnames
  • Remove venv-salt references:

    • Eliminates all venv-salt references since it is now enabled by default in the updated cucumber testsuite module, simplifying configuration and reducing redundancy.
  • Convert classic uyuni master to podman container

Related links:

Related to: https://github.com/SUSE/spacewalk/issues/25062

Specific sub-task linked into this PR thread history

Depends on: https://gitlab.suse.de/galaxy/infrastructure/-/merge_requests/987
Depends on uyuni-project/sumaform#1662 but can be merge before. Using this changes in a temporary branch.

@maximenoel8 maximenoel8 self-assigned this Nov 24, 2024
@maximenoel8 maximenoel8 requested a review from a team November 24, 2024 22:33
@maximenoel8 maximenoel8 changed the title Uyuni prv rename hostname and module names UYUNI MASTER PRV - rename module names and remove configurations to use cucumber testsuite default values and convert to podman Nov 24, 2024
@maximenoel8 maximenoel8 force-pushed the uyuni_PRV-rename_hostname_and_module_names branch from eefe9b0 to 238a91a Compare November 24, 2024 23:23
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See question

otherwise LGTM

@maximenoel8 maximenoel8 merged commit b5871d2 into SUSE:master Nov 25, 2024
1 check passed
@maximenoel8 maximenoel8 deleted the uyuni_PRV-rename_hostname_and_module_names branch November 25, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants