Add support for more origin service configuration #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I completely forgot the certificate mounting portion... be right back! |
|
Ok, I've updated with the ability to mount certificates from either secrets or config maps. I went with CLI options to provide a more opinionated out-of-the-box configuration, but perhaps its better to allow arbitrary volume mounts in the controlled container? That might make it easier to integrate with i.e. the cert-manager CSI. Let me know if you'd like any changes! |
UnstoppableMango
force-pushed
the
origin-ca-pool
branch
2 times, most recently
from
2c24a4e to
8960062
Compare
UnstoppableMango
force-pushed
the
origin-ca-pool
branch
from
8960062 to
baeb312
Compare
UnstoppableMango
force-pushed
the
origin-ca-pool
branch
2 times, most recently
from
3c99559 to
4f2a173
Compare
Integration tests WIP adding config map/secret mounting Properly pass CaPool values Refactoring and cleanup Revert imports moving around Not sure why that happened Refactor to just forward controller volume mounts I gave this some more thought and I think just letting consumers mount volumes to the controller and then forward those to the cloudflared pod would be better. Curious what you think! Rebase conflict
UnstoppableMango
force-pushed
the
origin-ca-pool
branch
from
4f2a173 to
62baba2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for a few more origin service settings via annotations similar to proxy ssl verify.
https://developers.cloudflare.com/cloudflare-one/connections/connect-networks/configure-tunnels/origin-configuration/
I tried to follow the existing conventions, but I did make a minor refactor around ProxySSLVerify/NoTLSVerify. Let me know if there's anything you want changed!
I believe this should resolve #11 and #16