Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SystemEntity and EntityManager #767

Open
dlyr opened this issue May 23, 2021 · 1 comment
Open

SystemEntity and EntityManager #767

dlyr opened this issue May 23, 2021 · 1 comment
Labels
Engine Related to Ra::Engine

Comments

@dlyr
Copy link
Contributor

dlyr commented May 23, 2021

EntityManager create and manage the singleton SystemEntity.
This seems to be a design flaw since EntityManager can now be deleted.
As introduce in #763 , EntityManager dtor now deletes the SystemEntity, which seems odd for a singleton.
I propose to discuss this point in Discussions if needed, then to fix this issue.

@MathiasPaulin
Copy link
Contributor

EntityManager create and manage the singleton SystemEntity.
This seems to be a design flaw since EntityManager can now be deleted.

I agree. I opened a discussion (#768) to discuss how to solve this design flaw.

@nmellado nmellado added the Engine Related to Ra::Engine label May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engine Related to Ra::Engine
Projects
None yet
Development

No branches or pull requests

3 participants