Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Follows You" update to feature version 2 #490

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

"Follows You" update to feature version 2 #490

wants to merge 4 commits into from

Conversation

Wilamaxin
Copy link
Collaborator

This feature has some visibility issues when used along with Scratch Addons addon "Profile Banner". I couldn't fix that. Any ideas on how to fix that are welcome.

Wilamaxin added 3 commits May 25, 2023 22:42
@Wilamaxin
"Follows You" update to feature version 2
6028d05 
This feature has some visibility issues when used along with Scratch Addons addon "Profile Banner". 
I couldn't fix that. Any ideas on how to fix that are welcome.
@Wilamaxin
Delete follows-you.js
f708f78
@Wilamaxin
Fix visibility issue
f1b38dd 
Fixes visibility issue that occurred when used with Scratch Addons addon "Profile Banner" enabled.
@Wilamaxin
Copy link
Collaborator Author

Issue fixed.

rgantzos
rgantzos requested changes May 28, 2023
View reviewed changes
Copy link
Member

@rgantzos rgantzos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You updated multiple features in features.json.

@Wilamaxin
Copy link
Collaborator Author

You updated multiple features in features.json.

That's the only way I can do it (please tell me if there is any other way that wouldn't cause file conflicts). Keep in mind that all PRs should be merged in the order I requested them.

@Wilamaxin
Copy link
Collaborator Author

I can also not edit features.json. at all and keep it up to someone else to change when merging (then the order can be arbitrary)

@Wilamaxin Wilamaxin requested a review from rgantzos May 28, 2023 21:03
@Wilamaxin
Copy link
Collaborator Author

File conflict example #489

@Wilamaxin
Copy link
Collaborator Author

@rgantzos then what should I do?

@rgantzos rgantzos added priority: 3 Least important. status: needs review Waiting for further review. scope: feature type: enhancement Makes an existing feature better and removed priority: 3 Least important. labels Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgantzos rgantzos Awaiting requested review from rgantzos

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
scope: feature status: needs review Waiting for further review. type: enhancement Makes an existing feature better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wilamaxin @rgantzos