Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JUnit tests #11

Open
Cael35 opened this issue Jun 5, 2018 · 7 comments
Open

Add JUnit tests #11

Cael35 opened this issue Jun 5, 2018 · 7 comments
Assignees

Comments

@Cael35
Copy link

Cael35 commented Jun 5, 2018

There is automated tests but not with JUnit.
The idea is to make JUnit tests that run PitMP on dhell and dnoo, using the plugin maven-plugin-testing-harness.
Then we can have a meaningfull "coverage". :-)

@Cael35
Copy link
Author

Cael35 commented Aug 3, 2018

All automated tests files are located in the directory test_dir.
First, reproduce the same test suite using JUnit.
PIT uses maven-plugin-testing-harness, so have a look at it and maybe we could even use some classes.

@pedrorijo91
Copy link
Contributor

I may be interested in helping on this issue :)

@nicolabertazzo
Copy link
Contributor

nicolabertazzo commented Sep 7, 2018

Hi @pedrorijo91,

your help is greatly appreciated.
I'll start working on the conversion of the tests to JUnit in the next week and I'll asign to you some tasks about this activity.

Do you agree?

@pedrorijo91
Copy link
Contributor

cool! :)

@Cael35
Copy link
Author

Cael35 commented Sep 10, 2018

Thanks for your help guys !
It would be great to first reproduce the tests executed by verify_pitmp.sh. It runs PitMP on several projects with 2 different configurations. All files can be found in the directory test_dir. Let me know if you have any questions.

nicolabertazzo pushed a commit to nicolabertazzo/pitmp-maven-plugin that referenced this issue Sep 10, 2018
Changed verify goal to run Java Integration Tests.
nicolabertazzo pushed a commit to nicolabertazzo/pitmp-maven-plugin that referenced this issue Sep 18, 2018
nicolabertazzo pushed a commit to nicolabertazzo/pitmp-maven-plugin that referenced this issue Sep 18, 2018
@pedrorijo91
Copy link
Contributor

hey @nicolabertazzo,

do we already have a plan to tackle this?

@Cael35
Copy link
Author

Cael35 commented Oct 18, 2018

Once #34 will be merged, we can enhance the test suite.
Here are some ideas for the test cases :-)

  • Make at least one test for each property defined in the mojos ('run' for PitMP with Gregor and 'descartes' for PitMP with Descartes)
  • Verify all tests on projects dhell and dnoo
  • Automatically check the result of execution using XML result files (keep reference files validated by hand, and compare the execution file and the reference file)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants