tests: housekeeping, test_authentication.py #7509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlavu
force-pushed
the
cherry-pick-test-auth
branch
2 times, most recently
from
f25866a to
80c539f
Compare
"This commit does not belong to any branch on this repository" |
danlavu
force-pushed
the
cherry-pick-test-auth
branch
from
80c539f to
0a3acc9
Compare
|
@alexey-tikhonov fixed. |
housekeeping, the following is looked at and may have been done: * fixed typos and standardized formatting * renamed test cases to improve the clarity of what the test does * improved docstring language, setup, steps and expected results * synced code with the docstring order * removed necessary configuration relevant to the test * added pytest.mark.importance to test cases noteable changes: * big rename on the test case names, after discussing that some cases will have the positive and negative test, it no longers to be specified (cherry picked from commit 7716d13)
danlavu
force-pushed
the
cherry-pick-test-auth
branch
from
0a3acc9 to
4aaef80
Compare
danlavu
changed the title
danlavu
requested review from
alexey-tikhonov
and removed request for
alexey-tikhonov
thalman
requested changes
Aug 14, 2024
|
CI failures are not related to the PR |
|
@jakub-vavra-cz, can we merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
housekeeping, the following is looked at and may have been done:
noteable changes:
(cherry picked from commit 7716d13)