Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen height hack mobile #38

Open
JobDoesburg opened this issue Feb 15, 2021 · 1 comment
Open

Screen height hack mobile #38

JobDoesburg opened this issue Feb 15, 2021 · 1 comment

Comments

@JobDoesburg
Copy link
Contributor

The mobile screen height hack increases and decreases the header height if the viewport inner height changes (for mobile browsers with a toolbar). However, this makes the total content height change as well when switching toolbar visibility. When the header is in view, this is not bad and actually even expected, but when a different section is in view that does not respect the max. viewport height, this triggers some glitchy movements.

Solutions:

  • only apply the inner height hack if the header is in view
  • Add some variable margin to the bottom of the header so the other sections will start at the correct place
  • let the first section start at a fixed coordinate regardless of header height
@JobDoesburg JobDoesburg changed the title Screen height hack causes glitches Screen height hack mobile Jul 13, 2021
@JobDoesburg
Copy link
Contributor Author

Ignore message above

The current website does use a lot of 100vh sections. However, on iPhone , a menu bar will hide the partner banner for this. There is a hack to do this (but it can be glitchy). We should investigate this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant