Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper error translate #175

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Helper error translate #175

merged 5 commits into from
Mar 27, 2024

Conversation

bsilkyn
Copy link
Contributor

@bsilkyn bsilkyn commented Mar 25, 2024

helper functions have error processor function, which makes a toast message for an error. However, these messages are currently only available in english. It would be great if these were also available in Dutch.

closes #149

@bsilkyn bsilkyn added the frontend Issues regarding the frontend label Mar 25, 2024
@bsilkyn bsilkyn added this to the Frontend milestone milestone Mar 25, 2024
@bsilkyn bsilkyn self-assigned this Mar 25, 2024
@bsilkyn bsilkyn marked this pull request as ready for review March 25, 2024 22:32
@bsilkyn bsilkyn marked this pull request as draft March 26, 2024 09:43
Copy link
Contributor

@tyboro2002 tyboro2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If merge conflicts are fixed this can be merged

"serverDetail": "Er vond een fout plaats op de server.",
"network": "Netwerk Fout",
"networkDetail": "Kan de server niet bereiken.",
"request": "Verzoek Fout",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Er is een fout verzoek ontvangen.

"helpers": {
"errors": {
"notFound": "Niet Gevonden",
"notFoundDetail": "Resource niet gevonden.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Resource/Bron/

"notFound": "Niet Gevonden",
"notFoundDetail": "Resource niet gevonden.",
"unauthorized": "Onbevoegd",
"unauthorizedDetail": "Je bent niet bevoegd om deze resource te bereiken.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Resource/Bron/

@tyboro2002 tyboro2002 marked this pull request as ready for review March 27, 2024 06:07
@tyboro2002 tyboro2002 merged commit 696a365 into development Mar 27, 2024
2 checks passed
@bsilkyn bsilkyn deleted the helper-error-translate branch April 5, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issues regarding the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add errors
2 participants