From e7f319b3fd3bc6f157d3b333443bb67d2dec64df Mon Sep 17 00:00:00 2001
From: EwoutV <ewoutverlinde@hotmail.com>
Date: Tue, 16 Apr 2024 13:21:32 +0200
Subject: [PATCH] chore: improved project progressbar, linting

---
 frontend/src/components/forms/Editor.vue             |  1 -
 frontend/src/components/projects/ProjectCard.vue     | 12 ++++++++++--
 frontend/src/components/projects/ProjectList.vue     |  2 +-
 .../src/test/unit/services/setup/get_handlers.ts     |  1 -
 frontend/src/test/unit/types/course.test.ts          |  2 +-
 frontend/src/types/Course.ts                         |  2 +-
 frontend/src/types/Project.ts                        |  2 +-
 7 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/frontend/src/components/forms/Editor.vue b/frontend/src/components/forms/Editor.vue
index 62893032..b68a9585 100644
--- a/frontend/src/components/forms/Editor.vue
+++ b/frontend/src/components/forms/Editor.vue
@@ -1,6 +1,5 @@
 <script setup lang="ts">
 import Editor from 'primevue/editor';
-import Button from 'primevue/button';
 
 const model = defineModel();
 </script>
diff --git a/frontend/src/components/projects/ProjectCard.vue b/frontend/src/components/projects/ProjectCard.vue
index 9aa28f84..0fbfb5ad 100644
--- a/frontend/src/components/projects/ProjectCard.vue
+++ b/frontend/src/components/projects/ProjectCard.vue
@@ -52,7 +52,7 @@ const { t } = useI18n();
         >
             <div class="p-5 surface-300 border-round">
                 <div class="flex align-items-center gap-5">
-                    <i class="pi pi-clock text-6xl" />
+                    <i class="pi pi-clock text-6xl text-primary" />
                     <div class="w-full">
                         <h3 class="m-0">{{ project.name }}</h3>
                         <div class="flex justify-content-between align-items-center mt-2">
@@ -96,7 +96,15 @@ const { t } = useI18n();
                     <b>{{ t('views.projects.submissionStatus') }}</b
                     >: ok
                 </div>
-                <ProgressBar class="mt-3" :value="project.getProgress()" />
+                <ProgressBar class="mt-3" :value="project.getProgress()">
+                    {{
+                        t(
+                            'views.projects.days',
+                            { hour: moment(project.deadline).format('H:m') },
+                            moment(project.deadline).diff(moment(), 'day'),
+                        )
+                    }}
+                </ProgressBar>
             </template>
             <template #footer>
                 <RouterLink
diff --git a/frontend/src/components/projects/ProjectList.vue b/frontend/src/components/projects/ProjectList.vue
index 8c7bc260..9748bb50 100644
--- a/frontend/src/components/projects/ProjectList.vue
+++ b/frontend/src/components/projects/ProjectList.vue
@@ -63,7 +63,7 @@ const incomingProjects = computed<Project[] | null>(() => {
                 <div class="grid">
                     <template v-if="incomingProjects !== null">
                         <template v-if="incomingProjects.length > 0">
-                            <div class="col-12" v-for="project in incomingProjects">
+                            <div class="col-12" v-for="project in incomingProjects" :key="project.id">
                                 <ProjectCard
                                     type="small"
                                     :project="project"
diff --git a/frontend/src/test/unit/services/setup/get_handlers.ts b/frontend/src/test/unit/services/setup/get_handlers.ts
index 52de20eb..6db68be1 100644
--- a/frontend/src/test/unit/services/setup/get_handlers.ts
+++ b/frontend/src/test/unit/services/setup/get_handlers.ts
@@ -13,7 +13,6 @@ import {
     structureChecks,
     submissions,
 } from './data';
-import { json } from 'stream/consumers';
 
 const baseUrl = 'http://localhost';
 
diff --git a/frontend/src/test/unit/types/course.test.ts b/frontend/src/test/unit/types/course.test.ts
index 122a06db..40ad5c6d 100644
--- a/frontend/src/test/unit/types/course.test.ts
+++ b/frontend/src/test/unit/types/course.test.ts
@@ -24,7 +24,7 @@ describe('course type', () => {
 
     it('create a course instance from JSON data', () => {
         const courseJSON = { ...courseData };
-        const course = Course.fromJSON(courseJSON as any);
+        const course = Course.fromJSON(courseJSON);
 
         expect(course).toBeInstanceOf(Course);
         expect(course.id).toBe(courseData.id);
diff --git a/frontend/src/types/Course.ts b/frontend/src/types/Course.ts
index 950627b4..d0a807ae 100644
--- a/frontend/src/types/Course.ts
+++ b/frontend/src/types/Course.ts
@@ -41,7 +41,7 @@ export class Course {
      *
      * @param course
      */
-    static fromJSON(course: Course|any): Course {
+    static fromJSON(course: Course): Course {
         const faculty =
             course.faculty !== undefined && course.faculty !== null ? Faculty.fromJSON(course.faculty) : null;
 
diff --git a/frontend/src/types/Project.ts b/frontend/src/types/Project.ts
index b3b12577..02f1c968 100644
--- a/frontend/src/types/Project.ts
+++ b/frontend/src/types/Project.ts
@@ -42,7 +42,7 @@ export class Project {
      *
      * @param project
      */
-    static fromJSON(project: Project|any): Project {
+    static fromJSON(project: Project): Project {
         let course = null;
 
         if (project.course !== null && project.course !== undefined) {