Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #590 | Add Dataloader Thai Elderly Speech #656

Merged
merged 1 commit into from
May 31, 2024

Conversation

akhdanfadh
Copy link
Collaborator

Closes #590

I implemented one config per subset. Thus, configs will look like this: thai_elderly_speech_healthcare_source, thai_elderly_speech_smarthome_seacrowd_sptext, etc. When testing, pass thai_elderly_speech_<subset> to the --subset_id parameter.

Checkbox

  • Confirm that this PR is linked to the dataset issue.
  • Create the dataloader script seacrowd/sea_datasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
  • Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _SEACROWD_VERSION variables.
  • Implement _info(), _split_generators() and _generate_examples() in dataloader script.
  • Make sure that the BUILDER_CONFIGS class attribute is a list with at least one SEACrowdConfig for the source schema and one for a seacrowd schema.
  • Confirm dataloader script works with datasets.load_dataset function.
  • Confirm that your dataloader script passes the test suite run with python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py.
  • If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

Copy link
Collaborator

@jensan-1 jensan-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akhdanfadh
Thank you for implementing this dataloader.
Tested, and LGTM! let's wait for the other reviewer

@holylovenia
Copy link
Contributor

Hi @patrickamadeus, I would like to let you know that we plan to finalize the calculation of the open contributions (e.g., dataloader implementations) in 31 hours, so it'd be great if we could wrap up the reviewing and merge this PR before then.

cc: @akhdanfadh

Copy link
Collaborator

@fhudi fhudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Passed the tests for both subsets.
Passed all items in the reviewing checklist.
Thanks for the hard-work.
Merging this soon.

@fhudi fhudi assigned fhudi and unassigned patrickamadeus May 31, 2024
@fhudi
Copy link
Collaborator

fhudi commented May 31, 2024

cc: @sabilmakbar

@fhudi fhudi merged commit d9b3154 into SEACrowd:master May 31, 2024
1 check passed
@akhdanfadh akhdanfadh deleted the thai_elderly_speech branch May 31, 2024 12:49
@fhudi fhudi removed the request for review from patrickamadeus May 31, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create dataset loader for Thai Elderly Speech dataset
6 participants