Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #278 | Add mywsl2023 dataloader #472

Merged
merged 9 commits into from
May 31, 2024

Conversation

Enliven26
Copy link
Contributor

@Enliven26 Enliven26 commented Mar 2, 2024

Closes #278

Checkbox

  • Confirm that this PR is linked to the dataset issue.
  • Create the dataloader script seacrowd/sea_datasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
  • Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _SEACROWD_VERSION variables.
  • Implement _info(), _split_generators() and _generate_examples() in dataloader script.
  • Make sure that the BUILDER_CONFIGS class attribute is a list with at least one SEACrowdConfig for the source schema and one for a seacrowd schema.
  • Confirm dataloader script works with datasets.load_dataset function.
  • Confirm that your dataloader script passes the test suite run with python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py.
  • If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

Copy link
Collaborator

@sabilmakbar sabilmakbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so far, the code looks okay to me, and the metadata is also correct. the actual implementation is still being tested (now downloading it since the total data is around 3GB)

Copy link
Collaborator

@sabilmakbar sabilmakbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@holylovenia holylovenia requested review from akhdanfadh and removed request for yongzx March 25, 2024 09:25
Copy link
Collaborator

@akhdanfadh akhdanfadh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the dataloader @Enliven26. Please see my comments below.

seacrowd/sea_datasets/mywsl2023/mywsl2023.py Outdated Show resolved Hide resolved
seacrowd/sea_datasets/mywsl2023/mywsl2023.py Outdated Show resolved Hide resolved
seacrowd/sea_datasets/mywsl2023/mywsl2023.py Show resolved Hide resolved
seacrowd/sea_datasets/mywsl2023/mywsl2023.py Outdated Show resolved Hide resolved
seacrowd/sea_datasets/mywsl2023/mywsl2023.py Outdated Show resolved Hide resolved
@Enliven26 Enliven26 requested a review from tellarin as a code owner March 28, 2024 11:32
@sabilmakbar sabilmakbar removed the request for review from tellarin March 29, 2024 18:08
@sabilmakbar sabilmakbar self-requested a review March 31, 2024 18:11
@Enliven26
Copy link
Contributor Author

I will try to commit all necessary changes at the end of this week

@Enliven26
Copy link
Contributor Author

Hi @sabilmakbar @akhdanfadh , please review my latest changes, thanks!

@akhdanfadh
Copy link
Collaborator

@Enliven26 A friendly reminder to address the reviews 😄

@Enliven26
Copy link
Contributor Author

@Enliven26 A friendly reminder to address the reviews 😄

I will try to commit all necessary changes next weekend, currently having trouble with remaining local disk space to redownload the dataset

@holylovenia
Copy link
Contributor

A friendly reminder for @Enliven26 to address @akhdanfadh's suggestions. 🙏

@holylovenia
Copy link
Contributor

holylovenia commented May 13, 2024

Hi @Enliven26, I would like to let you know that we plan to finalize the calculation of the open contributions (e.g., dataloader implementations) by 30 May, so it'd be great if we could wrap up the reviewing and merge this PR before then.

@holylovenia
Copy link
Contributor

Hi @Enliven26, I would like to let you know that we plan to finalize the calculation of the open contributions (e.g., dataloader implementations) in 31 hours, so it'd be great if we could wrap up the reviewing and merge this PR before then.

@Enliven26
Copy link
Contributor Author

Hello, I apologize for the inconvenience, but I'm still experiencing issues with my disk space. The remaining space I have is smaller than the size of the dataset, and as a result, I'm currently unable to run the unit test. I comitted the changes as suggested and I hope it will still pass the unit test. I'm really sorry for the trouble.

@sabilmakbar
Copy link
Collaborator

okay it runs correctly. Since @akhdanfadh's away and his review has been addressed, we can proceed to merge.
test_mywsl.log

@sabilmakbar sabilmakbar merged commit cb54a03 into SEACrowd:master May 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create dataset loader for MyWSL2023
5 participants