-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #278 | Add mywsl2023 dataloader #472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so far, the code looks okay to me, and the metadata is also correct. the actual implementation is still being tested (now downloading it since the total data is around 3GB)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the dataloader @Enliven26. Please see my comments below.
I will try to commit all necessary changes at the end of this week |
Hi @sabilmakbar @akhdanfadh , please review my latest changes, thanks! |
@Enliven26 A friendly reminder to address the reviews 😄 |
I will try to commit all necessary changes next weekend, currently having trouble with remaining local disk space to redownload the dataset |
A friendly reminder for @Enliven26 to address @akhdanfadh's suggestions. 🙏 |
Hi @Enliven26, I would like to let you know that we plan to finalize the calculation of the open contributions (e.g., dataloader implementations) by 30 May, so it'd be great if we could wrap up the reviewing and merge this PR before then. |
Hi @Enliven26, I would like to let you know that we plan to finalize the calculation of the open contributions (e.g., dataloader implementations) in 31 hours, so it'd be great if we could wrap up the reviewing and merge this PR before then. |
Hello, I apologize for the inconvenience, but I'm still experiencing issues with my disk space. The remaining space I have is smaller than the size of the dataset, and as a result, I'm currently unable to run the unit test. I comitted the changes as suggested and I hope it will still pass the unit test. I'm really sorry for the trouble. |
okay it runs correctly. Since @akhdanfadh's away and his review has been addressed, we can proceed to merge. |
Closes #278
Checkbox
seacrowd/sea_datasets/my_dataset/my_dataset.py
(please use only lowercase and underscore for dataset naming)._CITATION
,_DATASETNAME
,_DESCRIPTION
,_HOMEPAGE
,_LICENSE
,_URLs
,_SUPPORTED_TASKS
,_SOURCE_VERSION
, and_SEACROWD_VERSION
variables._info()
,_split_generators()
and_generate_examples()
in dataloader script.BUILDER_CONFIGS
class attribute is a list with at least oneSEACrowdConfig
for the source schema and one for a seacrowd schema.datasets.load_dataset
function.python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py
.