Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message: INVALID_DATE_ERROR is not covered in i18n nor exposed in FdLanguagePatch for external application translation #12839

Open
I528767 opened this issue Dec 12, 2024 · 0 comments

Comments

@I528767
Copy link

I528767 commented Dec 12, 2024

Is this a bug, enhancement, or feature request?
Bug

Can you handle that on the application side
No

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version.
fundamental-ngx(core,platform,i18n): 0.43.46
angular: 15.2.9

If this is a bug, please provide steps for reproducing it; the exact components you are using

  1. Set browser language to foreign language locale other than English, for instance Simplified Chinese.

  2. Select only one date in the Range Date Picker. You will see that other strings in the datePicker component are translated accordingly, but the invalid date error is hardcoded and cannot be translated.

image

Please provide relevant source code (if applicable).
INVALID_DATE_ERROR is defined in:
https://github.com/SAP/fundamental-ngx/blob/main/libs/cdk/utils/consts/error-messages.ts

Looks like this hardcoded error message is returned as formatted date by date adapter and therefore displayed in input filed without translation:
https://github.com/SAP/fundamental-ngx/blob/main/libs/core/datetime/fd-datetime-adapter.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant