Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent sample #27

Closed
mwdb opened this issue Feb 9, 2024 · 2 comments
Closed

Inconsistent sample #27

mwdb opened this issue Feb 9, 2024 · 2 comments
Assignees
Labels
contribution Valuable Contribution size/s Requires minimal effort to get changed. type/examples-samples Related to existing examples/samples, or request for new examples/samples. type/other Other documentation problem.

Comments

@mwdb
Copy link

mwdb commented Feb 9, 2024

Issue description

The sample below looks inconsistent:

For example, you want to send the phone attribute coming from the corporate IdP to the application. You have defined the following attribute in the administration console for SAP Cloud Identity Services:

Configuration of Attributes with Default Values in Administration Console
Attribute	Value
Phone	+49 ${corporateIdP.phone} Corporate Phone
SAML 2.0

</Attribute> 
				<Attribute Name="Phone"> <AttributeValue xmlns:xs="http://www.w3.org/2001/XMLSchema"
                                xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
                                xsi:type="xs:string"
                                >+49 Corporate Phone</AttributeValue>
</Attribute>

OpenID Connect

"Phone": "+49 Corporate Phone"

I'd expect something like
OpenID Connect

"Phone": "+49 6227-7 Corporate Phone"

Similar for SAML.

Feedback Type (Optional)

examples or samples

Page Title on SAP Help Portal (prefilled)

Configuring Attributes Based on Flexible Expressions

Page URL on SAP Help Portal (prefilled)

https://help.sap.com/docs/identity-authentication/identity-authentication/configure-default-attributes-sent-to-application?locale=en-US

@ValAta ValAta self-assigned this Feb 9, 2024
@ValAta ValAta added the contribution Valuable Contribution label Feb 9, 2024
Copy link

sap-doc-bot bot commented Feb 9, 2024

Thank you for your valuable feedback contribution, @mwdb! So that we can recognize your contribution in SAP Community, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this:

https://people.sap.com/your-user-name

Thanks!

@ValAta ValAta added the type/examples-samples Related to existing examples/samples, or request for new examples/samples. label Feb 9, 2024
@ValAta
Copy link
Contributor

ValAta commented Feb 9, 2024

Hi @mwdb ,
Thanks for the feedback. I have updated the documentation. You'll see the changes on the SAP Help Portal in the next documentation release.
BR

@ValAta ValAta closed this as completed Mar 14, 2024
@ValAta ValAta added size/s Requires minimal effort to get changed. type/other Other documentation problem. labels Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution size/s Requires minimal effort to get changed. type/examples-samples Related to existing examples/samples, or request for new examples/samples. type/other Other documentation problem.
Projects
None yet
Development

No branches or pull requests

2 participants