Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Life tasting. 2.20.1.1 #143

Open
Beholded opened this issue Dec 7, 2023 · 1 comment
Open

Life tasting. 2.20.1.1 #143

Beholded opened this issue Dec 7, 2023 · 1 comment

Comments

@Beholded
Copy link

Beholded commented Dec 7, 2023

Buff from tavern - Life tasting (+10%skill exp) seems not work.
Mb some tweaks or changes break it.
I try to change buff value via cheat engine to 1, 10, 100, 1000.
In description to buff value changes, but not affect any skill exp gain.

@JianmengYu
Copy link
Contributor

Tldr buff power value doesn't affect the fixed 110% growth modifier.

In skillexp function in 'module.hsp', it checks if
cdata(STARTING_CDATA_FOOD_EXP + SKILL_ATTR_LUC - RANGE_CDATA_FOOD_EXP, skillexp_charid) > 0
If the growth value is modified, it times the exp gained by 110%
locvar_skillmod_exp = locvar_skillmod_exp * 11 / 10
Which is set by the following line in LIFE_TASTING section in calcbuff in buff.hsp:
cdata(270 + 19 - 10, calcbuff_charid) = locvar_calcbuff_p

If you enabled 'revert post 190 exp changes', this will be disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants