DAO-842 Updated logic to correctly match allocation balance checking … #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Freshenext
force-pushed
the
DAO-842
branch
2 times, most recently
from
d5f493d to
1c8673f
Compare
jessgusclark
approved these changes
Nov 22, 2024
| query: { | ||
| enabled: false, | ||
| refetchInterval: 10000, |
There was a problem hiding this comment.
We are usually using 30 seconds since It's when the block changes.
antomor
reviewed
Nov 25, 2024
Comment on lines
+44
to
+46
| const parsedAmount = parseEther(amount) ?? 0n | ||
| const parsedBalance = parseEther(stRifBalance) ?? 0n | ||
| const balanceThatCanBeWithdraw = parsedBalance - (backerTotalAllocation || 0n) |
There was a problem hiding this comment.
@Freshenext I think it would be better to use a useMemo to just calculate canAccountWithdraw. In the past, we experienced a strange behaviour of useReadContract that was affected by not having a useMemo to perform calculation of the useReadContracts results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…process.