TOK-408: estimated rewards #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscotobar
force-pushed
the
TOK-408/estimated-rewards
branch
from
1da3d69 to
63fb1e8
Compare
franciscotobar
force-pushed
the
TOK-408/estimated-rewards
branch
from
63fb1e8 to
08e92e7
Compare
antomor
reviewed
Nov 11, 2024
| import { tokenContracts } from '@/lib/contracts' | ||
| import { Popover } from '@/components/Popover' | ||
| import { Button } from '@/components/Button' | ||
| import { Paragraph } from '@/components/Typography' | ||
|
|
||
| export const Rewards: FC<{ builder: Address; gauge: Address }> = ({ builder, gauge }) => { | ||
| console.log('🚀 ~ gauge:', gauge) |
There was a problem hiding this comment.
Should remove it? or do we want to keep it for debugging purposes?
antomor
reviewed
Nov 11, 2024
| import { Address } from 'viem' | ||
| import { useReadContract } from 'wagmi' | ||
|
|
||
| export const useGetRewardShares = (gauge?: Address) => { |
There was a problem hiding this comment.
I'd make the parameter required in the signature, otherwise it doesn't make sense for this function to exist.
Suggested change
| export const useGetRewardShares = (gauge?: Address) => { | |
| export const useGetRewardShares = (gauge: Address) => { |
antomor
reviewed
Nov 11, 2024
| @@ -71,8 +71,8 @@ export const AllTimeRewards: FC<AllTimeRewardsProps> = ({ gauge, data: { rif, rb | |||
|
|
|||
| useHandleErrors([ | |||
There was a problem hiding this comment.
I'd combine these errors into one
antomor
reviewed
Nov 11, 2024
| error: rbtcError, | ||
| } = useGetRewardMetrics(gauge, rbtcRewards ?? 0n, totalPotentialRewardsValue, rbtc.symbol, currency) | ||
|
|
||
| useHandleErrors([ |
There was a problem hiding this comment.
I'd combine these errors into one
antomor
approved these changes
Nov 11, 2024
franciscotobar
force-pushed
the
TOK-409/all-time-rewards
branch
from
8766ed7 to
7f0a332
Compare
franciscotobar
force-pushed
the
TOK-408/estimated-rewards
branch
3 times, most recently
from
8fca78d to
07da9ed
Compare
franciscotobar
force-pushed
the
TOK-409/all-time-rewards
branch
from
7f0a332 to
ec28fd6
Compare
franciscotobar
force-pushed
the
TOK-408/estimated-rewards
branch
from
07da9ed to
e2f9c69
Compare
jurajpiar
force-pushed
the
TOK-409/all-time-rewards
branch
from
ec28fd6 to
bfabaef
Compare
jurajpiar
force-pushed
the
TOK-408/estimated-rewards
branch
from
e2f9c69 to
1b628c5
Compare
jurajpiar
reviewed
Nov 12, 2024
jurajpiar
force-pushed
the
TOK-408/estimated-rewards
branch
from
1b628c5 to
65e7d09
Compare
franciscotobar
force-pushed
the
TOK-409/all-time-rewards
branch
3 times, most recently
from
2cf0de1 to
0d4951e
Compare
franciscotobar
changed the base branch from
TOK-409/all-time-rewards
to
develop
franciscotobar
force-pushed
the
TOK-408/estimated-rewards
branch
from
65e7d09 to
831531f
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Link