Fix of UI Rounding error on staking/unstaking amounts #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurajpiar
added a commit
that referenced
this pull request
Oct 24, 2024
* DAO-545 Added alert component to use whenever we're creating a proposal. (#85) * DAO-545 Added alert component to use whenever we're creating a proposal. * Linted * change buttons behavior * Changed default asset to RIF. Fixed Alert dismiss on the close icon. * Removed @todo --------- Co-authored-by: Rodrigo Santana Gonçalves <[email protected]> * Update package.json * DAO-555 Added voting power at snapshot. (#87) * change insufficient voting power message (#90) * DAO-559: Invalid USD conversion for RIF and stRIF (#89) * do not show usd price when is not possible to get it * format currency * format usd decimals * format small numbers * handle scientific notation * DAO-547: Fix invalid proposals (#91) * validate decimal places while user inputs the amount * minimum amount of 1 rif * fix NaN validation * calculate amount usd conversion * format treaury fiat amount * fix build * fix InputNumber props error * Added a new linting step to grab linting issues before merging. (#92) * PROPOSALS_OPTIMIZATION - Will now load proposals from cache in-memory (server) (#93) * PROPOSALS_OPTIMIZATION - Fixed caching (#94) * DAO-560 Added Footer in MainContainer.tsx (#96) * DAO-608 Add proposal to queue (#98) * DAO-588 Updated footer Brand to RootstockCollective (#97) * DAO-611: Update contract addresses (#99) * update addresses * change to RBTC * rename some contracts constants * fix e2e * DAO-590 Changed confirm button by Continue on Step Allowance (#100) * DAO-557: The number of decimals displayed should be the same across the dApp (#95) * treasury page * proposal page * user page * rename some input components * move form textarea and label * use input number on stake modal * format proposal votes * fix build * fix proposal form validation * DAO-555 We will now check the balance at snapshot to make sure that t… (#102) * DAO-555 We will now check the balance at snapshot to make sure that the user can vote. * Typofix * Removed followers button from communities (#103) * Will not go to new page when clicking community (#104) * Actions will show proper values. (#105) * Modified proposal create to use RIF (#106) * Added missing validation for casting vote (#107) * We will now have the Execute button. (#108) * DAO-597: Implement loading spinner (#101) * add loading spinner component * add loading to protected content * add loading button * add alert message for canceling transaction * loading request allowance * add loading to confirm staking button * add loading to unstaking button * pending claiming nft * fix build * DAO-557: Fix number of decimals displayed (#109) * adjust decimals * put loading spinner to vote and queue buttons * handle user cancel queuing proposal * fix voting power (#110) * feat: useCommunity hook for querying NFT view functions * fix: remove unused import * Bump the npm_and_yarn group across 1 directory with 3 updates (#83) Bumps the npm_and_yarn group with 2 updates in the / directory: [ws](https://github.com/websockets/ws) and [wagmi](https://github.com/wevm/wagmi/tree/HEAD/packages/react). Updates `ws` from 6.2.3 to 8.17.1 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@6.2.3...8.17.1) Updates `wagmi` from 2.10.10 to 2.12.1 - [Release notes](https://github.com/wevm/wagmi/releases) - [Changelog](https://github.com/wevm/wagmi/blob/main/packages/react/CHANGELOG.md) - [Commits](https://github.com/wevm/wagmi/commits/[email protected]/packages/react) Updates `fast-xml-parser` from 4.4.0 to 4.4.1 - [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases) - [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md) - [Commits](NaturalIntelligence/fast-xml-parser@v4.4.0...v4.4.1) --- updated-dependencies: - dependency-name: ws dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: wagmi dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: fast-xml-parser dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump the npm_and_yarn group across 1 directory with 2 updates (#113) Bumps the npm_and_yarn group with 2 updates in the / directory: [axios](https://github.com/axios/axios) and [elliptic](https://github.com/indutny/elliptic). Updates `axios` from 1.7.2 to 1.7.4 - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.7.2...v1.7.4) Updates `elliptic` from 6.5.5 to 6.5.7 - [Commits](indutny/elliptic@v6.5.5...v6.5.7) --- updated-dependencies: - dependency-name: axios dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: elliptic dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: NFT address in .env * Dao 627 (#114) * DAO-627 Added new method to transfer erc20 tokens from new treasury * If tokenAddress is the zero address, then use the normal transfer method. * Added an enhancement that shows how many blocks are left until a proposal is closed. (#115) * DAO-638 Removed container class and added margin-right to main container. (#118) * DAO-585 Added MetricsSection.tsx in the treasury page. Fixed proposals error. (#117) * fix: will show Execute button only when the proposal is queued. (#119) fix: will show vote on chain only when the proposal is active. fix: will show put on queue when the proposal is successful. fix: removed Publish button on the second step. fix: proposals will be truncated 20 characters. fix: removed duplicated/not needed css * DAO-621: Implement Alert Messages (#116) * create alert context provider * add pending message for staking * show message for changing staking status * clear message on route change * create TxStatusMessage component * check for unstaking tx * fix toFixed isNaN * fix build * match design alert * remove unused files * add alert messages for queuing * fix build * handle queue errors * DAO-637: fix alerts (#122) * DAO-633: Fix User page (#121) * disable stake and unstake button if don't have enough balance * user page changes * add font sora as default * adjust community header size * DAO-627 fix: will change validation when the token selected is RBTC (… (#123) * DAO-627 fix: will change validation when the token selected is RBTC (zero address) * fix: updated validation message. feat: added RBTC icon. * fix: moved rbtc to a separated file. * fix: will disable button when put on queue is loading (#124) * CopyButton component (#125) * feat: copy button component * fix(CopyButton): fix min width * refactor(CopyButton): simplify the component * refactor(CopyButton): use children instead of label * refactor(CopyButton): rename vars * fix: updated margin right to be 16px for the main container (#126) * DAO-632: fix Wallet not connected (#120) * modal changes * add icon * change to normal paragraph * DAO-634 fix: added icons that match the design. (#127) fix: added startIconClasses to button so that we can modify the classes of the container that has the icons. fix: added margin top of 4rem per design requirements between buttons and useful links. * fix treasury amount (#128) * DAO-614 fix: fixed overflow. feat: added NFT details. fix: added new endpoint to fetch nftinfo fix: hidden website links for now * New proposal should be listed at the top (#131) * chore: change Early Adopters community description and layout (#132) * fix: added RBTC minimum amount (#133) * fix: fixed sidemenu size - the padding was reducing the size. (#134) * Upgrade next and fix warning for images (#137) * fix: check if user is already connected - if true then redirect him t… (#135) * fix: check if user is already connected - if true then redirect him to /user else do nothing * fix: modified to Redirecting * Fix Invalid message when rejecting a voting operation (#138) * DAO-636: fix modals (#129) * font-family * skip allowance step if has enough amount allowed * fix max steps checking * adjust custom staking footer * prevent calling onGoNext twice * make cancel and requet allowance buttons in the same row * wait for pendind allowance request * adjust paddings * show message when allowance fails * fix allowance tx status checking * adjust last staking step * unset dismissed when change txHash * fix build * let the user know he has enough allowance to stake * fix: will check every 5s if the user has enough threshold to vote. Will also check if the user has voted (#140) * fix: added Staked to STRIF (#141) * DAO-641: Fix user is able to connect with a different network (#142) * check for changing network * move content to MainContainerContent * fix typo * Fix nft address (#143) * feat: Add to wallet button * refactor: useCommunity hook * Bump micromatch in the npm_and_yarn group across 1 directory (#139) Bumps the npm_and_yarn group with 1 update in the / directory: [micromatch](https://github.com/micromatch/micromatch). Updates `micromatch` from 4.0.7 to 4.0.8 - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md) - [Commits](micromatch/micromatch@4.0.7...4.0.8) --- updated-dependencies: - dependency-name: micromatch dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: add 3 alternative ipfs gateways for fetching NFT meta instead of one (#145) * Dao 615 (#146) * DAO-615 fix: user should be able to see his NFT in the user's page. * fix: JoinACommunity.tsx will redirect to communities page * DAO-643 feat: Renamed treasuries. (#147) feat: reduced code implementation. * Avoid showing wrong network alert when connecting (#148) * Enhance Voting Flow and Feedback in Proposal Modal (#149) * add loading spinner to vote button * handle cast voting error * disable voting button when is voting still pending * fix: treasury page layout and nft link (#151) * DAO 646: Display identifier in the footer (#150) * Create variable in .env file and have it show on the home. * Fix lint issue * Lint, again * Lint again 2 * Add step to deploy script. * [TEMP] test process by updating deploy script * Check if variable exists first. * Update docker deploy script to pass the variable during build not in .env * Fix lint issue. * Modify Dockerfile to include env variable from github. * Single source github org * Reset deploy workflow to use push * Bump webpack in the npm_and_yarn group across 1 directory (#144) Bumps the npm_and_yarn group with 1 update in the / directory: [webpack](https://github.com/webpack/webpack). Updates `webpack` from 5.92.1 to 5.94.0 - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.92.1...v5.94.0) --- updated-dependencies: - dependency-name: webpack dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Rename treasury .env variable names to grants, growth, general, and grantsActive (#152) * Implement link to explorer design for the treasury (#153) * Bump Version * remove border for the last accordion item (#155) * Change treasury buckets order (#156) * make buckets addresses in lower case to fix balance fetching (#157) * fix handle executing vote actions (#158) * Refine proposal (#159) * refine proposal validation form * format proposal actions * change to 1.0 to give the decimal idea * change general bucket address (#161) * fix: address being copied instead of nftAddress (#162) * Add NFT to wallet fix (#163) * chore: replace metamask with injected in wagmi config * fix: remove accounts request from addToWallet * fix: add loading state for Add nft button * fix: metrics card layout (#164) * fix: metrics card layout * fix: reduce metrics card header letter spacing * fix: avoid wrapping obj witha paragraph * fix: remove unused code * chore: add newly deployed sc addresses to .env * feat: compare NFT threshold with StRif balance * chore: add new contracts ABIs * feat: nft mint failure message * feat: before minting NFT, check that user owns enough StRIFs * hotfix: edited grants active address (#169) * sidemenu sorting and update user section name (#171) * footer update (#172) * Change Early Adopters community image (#170) * chore: change early adopters community image * chore: rename png images * feat: proposal ID copy button (#173) * fix: add nft to wallet button reset * Add Twitter link (#177) * Create LICENSE (#176) * DAO-673 feat: Updated main color. (#178) * DAO-673 feat: Updated main color. fix: Fixed an issue when voting the app is crashing. * feat: updated main color for icons * DAO-672 feat: updated testnet treasury contract with its new abi (#179) * DAO-673 Claim it button color change (#180) * Update Footer.tsx (#181) Add link to whitepaper * DAO-673 fix: edited box shadow of icon of the modal to match design. (#182) * DAO-673 fix: edited box shadow of icon of the modal to match design. fix: changed background color fix: removed unused paragraph component from two components * fix: proposal created metrics card adjusted width * DAO-669: Update landing page design (#175) * change login background * add kk-topo font * fix typo * buttons * add wordmark * prevent Hydration error when build id is set * install rootstock sans font * disclaimer screen * add connect button variants * do not cut the gradient * footer in landing page * footer rest the app * make black background for landing page * remove unused code * decrease width of disclaimer text * add disagree button * update logo * Update LICENSE * fix: update AWS configuration values (#183) * fix: update AWS configuration values * feat: add deploy workflows for dev and mainnet * Update backend URL * DAO-668 Updated mainnet contracts (#188) * DAO-HOTFIX fix: updated links (#190) * DAO-FEAT Updated mainnet contracts - removed multicall usage for now (#191) * More workflow fixes (#189) * fix: use mainnet PROFILE for mainnet deploy * feat: use per-env image repository * DAO-CHAINID Added chain id (#192) * DAO-UPDATED-FONTS feat: fonts updated (#193) * DAO-UPDATED-FONTS feat: fonts updated * fix: useful links fix as they were overlapping * fix: added env to footer (#194) * update footer (#196) * update communities header (#197) * Update Socials and Links (#185) * Update Footer.tsx Adding the discourse link that currently is not operational but will be shortly. * Remove Slack Link * Update constants.ts to use new Github org * Update <title>. * lint -new line * patch: change rif wallet services url (#198) * Revert "patch: change rif wallet services url (#198)" (#200) This reverts commit c1af979. * fix: removed text-center from disclaimer text (#199) * fix: removed text-center from disclaimer text fix: copyright text adjusted (styling and text) fix: stake/unstake buttons removed underline fix: removed table borders. Added first border only on first row. Added font weight bold on header (thead). Increased font size of headers and cells to 14px. fix: added telegram to footer and linted. fix: prefixed USD to currencies (in treasury and user screen) * update font * applying missing font --------- Co-authored-by: Rodrigo Santana Gonçalves <[email protected]> * Add SECURITY.md file (#201) * new symbol for stRIF (#203) * update backend url for prod (#204) * DAO-680 feat: added new link token resources in sidebar. (#202) * DAO-680 feat: added new link token resources in sidebar. feat: updated communities picture * Removed PNG * check balanceOf query (#205) * check balanceOf query * add multicall address * Implement mainnet governance configuration (#206) * Add link to faq and open in new window. (#208) * fix form (#209) * change the root page to user page when user is logged in (#210) * DAO-688 fix: Removed rewards text (#211) * chore: new mainnet addresses (#214) * hotfix: lower case addresses (#215) * fix popover when proposal is being executed. (#212) * prevent sidebar wrapping (#213) * hotfix: updated congratulations on stake text (#216) * DAO-683: Fix UI issues (#217) * add metamask icon * match design changes * fix: updated staking fonts (#218) * fix voting power popover (#219) * feat: added symbol when staking/unstaking (#220) * feat: added symbol when staking/unstaking * feat: added color for queue * Fix navigation menu width (#221) * Fix navigation menu width * feat: changed flex-auto by flex-1 --------- Co-authored-by: Francis Rodriguez <[email protected]> * Change trigger to push to main (#223) * Suggestion to user to stake RIF when minting NFT (#224) * fix stRIF typo * suggest to user to stake RIF when minting NFT * DAO-686: Add checksum conversion (#225) * check for invalid checksum * checks if the address has valid eip-55 checksum or in lower case * fix address * add terms of use (#226) * add data test-id for allowance button (#227) * DAO-VOTING-FIX feat: removed proposal voting threshold * DAO-619 Edited staking text * DAO-645 Will update sentiment column when new proposal is fetched. (#231) * fix: doesn't break ui if proposal not parsable' (#233) * Change trigger release (#232) * Change trigger for mainnet and testnet deployment on release. * Add in the environment variable and use the public facing URLs. * DAO-697 Added test-id locators (#234) * DAO-697 Added test-id locators * Fix lint * DAO-712 Added link in read the terms and conditions (it also exists in the Terms of Use) * DAO-689 Added white-space css rule to account for new line. * DAO-720 feat: Implemented Time Remaining Column. (#241) feat: Revamped proposals to use context. feat: Reduced api calls to backend. feat: Separated each column into its own file. feat: separated proposal state into its own hook. fix: added refetch interval to voteOnProposal to avoid unnecessary calls to node * Dao 721 Implemented quorum part in the Votes Column (#242) * DAO-721 Implemented quorum column * Implemented memoized latest proposals table to speed up UI. * Quorum will have no decimals place per Product. * Quorum percentage will be integer only, no decimals. * DAO-708 Reduced number of JS files when building. (#237) * DAO-694 Fixed hover. Fixed overflowing votes. (#236) * TimeRemainingColumn.tsx time adjusted - calculations were off. (#247) * TimeRemainingColumn.tsx time adjusted - calculations were off. * Quorum will not show NaN * DAO-703 Create new .env file for development and update .env file for testnet (#238) * feat: add env.dev file * refactor: update stRIF, Governor, EANFT addresses * refactor: update Docker to use .dev * refactor: README to add .env description * Update .env.dev url Co-authored-by: Lucas <[email protected]> --------- Co-authored-by: Francis Rodriguez <[email protected]> Co-authored-by: Lucas <[email protected]> * DAO-710 feat: added HeaderTitle.tsx which is the typography that will… (#244) * DAO-710 feat: added HeaderTitle.tsx which is the typography that will be used for section titles. BREAKING CHANGE: changed background color and foreground color fix: removed plus icon from create proposal button. fix: will now use HeaderTitle in the HeaderSection for proposals page fix: will use HeaderTitle in the proposals page where latest proposals is fix: edited columns name fix: edited date output format feat: edited MetricsCard.tsx to account for new style changes. fix: My voting power in proposals is not a metric card anymore; this component was created there. fix: adjusted width of metrics card of proposals created to 272 pixels fix: camel case my voting power fix: proposal name column will not wrap, and the text will be white due to new changes in the table design. BREAKING CHANGE: table header will now contain new style changes. BREAKING CHANGE: the table will have no rounded borders anymore due to design change. BREAKING CHANGE: table head color has changed to the foreground per new design changes fix: exported Typography type so it can be used. * fix: will now use variant light for span * DAO-711 Implemented new coming soon NFTs (#248) * Dao 717 Implemented gradient (#246) * DAO-710 feat: added HeaderTitle.tsx which is the typography that will be used for section titles. BREAKING CHANGE: changed background color and foreground color fix: removed plus icon from create proposal button. fix: will now use HeaderTitle in the HeaderSection for proposals page fix: will use HeaderTitle in the proposals page where latest proposals is fix: edited columns name fix: edited date output format feat: edited MetricsCard.tsx to account for new style changes. fix: My voting power in proposals is not a metric card anymore; this component was created there. fix: adjusted width of metrics card of proposals created to 272 pixels fix: camel case my voting power fix: proposal name column will not wrap, and the text will be white due to new changes in the table design. BREAKING CHANGE: table header will now contain new style changes. BREAKING CHANGE: the table will have no rounded borders anymore due to design change. BREAKING CHANGE: table head color has changed to the foreground per new design changes fix: exported Typography type so it can be used. * fix: will now use variant light for span * DAO-715 fix: metrics card will now use span instead of paragraph to better reflect its purpose for the fiatAmount. fix: the contractAddress link will have a margin top fix: MetricsSection.tsx will now use HeaderTitle fix: TotalTokenHoldingsSection.tsx will now use HeaderTitle fix: TreasurySection.tsx will use HeaderTitle. The metrics card will be borderless to reflect new design changes. * DAO-717 feat: added new button variant (sidebar-active) feat: added new component DivWithGradient.tsx feat: added gradient classes in the globals.css feat: added GradientHeader.tsx fix: removed classes from Header as design changes required it. fix: the sidebar will now have the ConnectedComponent prop which will be used to render that component. feat: added gradient header to sidebar feat: added gradient border to sidebar buttons fix: useful links added padding left feat: created SidebarButton component to implement DRY. * DAO-707 LastBlock in the frontend implemented (#235) * DAO-721: fix: will count for, abstain vote only. (#251) fix: renamed votes column * DAO-703 Updated dev deploy to use dev env (#252) * DAO-699 Created error boundary component (#249) * DAO-724 fix:Fonts revised so that they match the design. (#250) fix: changed favicon.ico * DAO-XXX The treasury strif will show rif price as default (#253) * DAO-XXX-Route fix: cached proposals additional process logic for prod build (#254) * Dao xxx env dev old (#255) * DAO-XXX-ENV-DEV-OLD Will use old parameters as the current parameters are way too fast. * fix: time remaining should only render if status = active due to network and performance purposes * feat: increased proposal chars to 50 (#256) * Update package.json (#257) * Remove legacy rsk-utils package (#258) * Remove legacy rsk-utils package and copy/paste in the methods we need. - this is a temporary step to get this working for the release. - when we have more time, we may create a new reusable package for these methods. * Pass in chainId property. * Use methods from viem * Add exception to ts rule. * Revert "Remove legacy rsk-utils package (#258)" (#259) This reverts commit 754656a. * Revert "DAO-686: Add checksum conversion (#225)" (#260) * Revert "DAO-686: Add checksum conversion (#225)" This reverts commit fbbb4f7. * remove line break to trigger GH action. * refactor: fetch proposals reduced to 10 secs (#264) * Revamp CD for dev environments (#263) * feat: add deployment for staging environment * fix: update the AWS config values for dev environment * feat: added .env.qa * fix: updated Dockerfile to account for new QA env --------- Co-authored-by: Francis Rodriguez <[email protected]> * Fix of UI Rounding error on staking/unstaking amounts (#262) * build: install testing libraries * config: vitest * fix: vitest config * fix: staking context provider * DAO-XXX-BG-FIX fix: background image not being built by tailwind css dynamically. Had to use another method so that the BG renders properly. (#265) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Francis Rodriguez <[email protected]> Co-authored-by: Rodrigo Santana Gonçalves <[email protected]> Co-authored-by: Jesse Clark <[email protected]> Co-authored-by: Alex <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Francis Rodriguez <[email protected]> Co-authored-by: Alexander Ivchenko <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: Bernardo Codesido <[email protected]> Co-authored-by: sleyter93 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix of UI Rounding error on staking/unstaking amounts . Details here
Ref
DAO-677