Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix of UI Rounding error on staking/unstaking amounts #261

Closed
wants to merge 6 commits into from
Closed

Fix of UI Rounding error on staking/unstaking amounts #261

wants to merge 6 commits into from

Conversation

shenshin
Copy link
Contributor

@shenshin shenshin commented Oct 9, 2024

What

Fix of UI Rounding error on staking/unstaking amounts . Details here

  • Install Vitest + testing-library/react
  • write a Vitest crush test (hundreds of repeats with different incoming params) proving that the issue really existed in ~9 % of the cases with the integer (whole) number input.
  • patch the StakingProvider
  • now the test is passing

Ref

DAO-677

@shenshin shenshin closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Freshenext Freshenext Awaiting requested review from Freshenext

@jessgusclark jessgusclark Awaiting requested review from jessgusclark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shenshin