Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvment for umbrel installs in custom directories #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

guiand888
Copy link

If user has Umbrel in a customer directory, the script will fail. Not a frequent occurence but this is an option in the Umbrel install script.

One workaround would be to:

  1. Check if docker is installed.
  2. Check if container named lightning_lnd_1 is running since this is a "signature" Umbrel container name for lnd.
  3. Run lncli with docker exec -i lightning_lnd_1 lncli instead

This also nulls the need to do a version check. The lnd container name has remained the same since inception.

@RooSoft RooSoft requested a review from dsbaars July 10, 2023 15:51
@RooSoft
Copy link
Owner

RooSoft commented Jul 10, 2023

@dsbaars do you still animate some RoF?

Been a while since I've had the chance to do it, would be nice to have someone competent review this nice little PR, but I don't feel like the right one to do it.

Thanks @guiand888!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants