Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add light theme + theme switch #13

Open
FaberVitale opened this issue Dec 22, 2022 · 0 comments
Open

add light theme + theme switch #13

FaberVitale opened this issue Dec 22, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@FaberVitale
Copy link
Collaborator

FaberVitale commented Dec 22, 2022 •
edited
Loading

Describe the problem

I want to be able to toggle between light and dark theme.

Describe the proposed solution

1. Add white theme

design a nice light theme then edit https://github.com/Roma-JS/roma-js-on-astro/blob/main/src/styles/main.scss#L144

2. Create theme switcher

add to the navbar a toggle button that on click switches between light and dark theme:

document.documentElement.classList.toggle(...)
  1. Persist user preference

You need to check in a render blocking script that the default theme matches what the user has selected.

How to create a romajs theme

  1. Create a cool theme in src/styles/main.scss
/* src/styles/main.scss */
:root.rmjs-my-cool-new-theme,
.rmjs-yellow-white-theme {
  color-scheme: light; /* or dark */
  --bg-primary: var(--brand-secondary);
  --bg-secondary: var(--color-light-100);
  --bg-tertiary: var(--color-dark-200);
  --text-primary: var(--color-dark-100);
  --text-secondary: var(--color-dark-100);
  --accent-primary: var(--brand-secondary);
}
  1. Apply theme
<html lang="it" class="rmjs-my-cool-new-theme">
<!-- awesome website here -->
</html>

Alternatives considered

We could use a drop-down menu of we want to support more than 2 themes... but it does not seem that useful atm.

Importance

nice to have
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
RomaJS Opensource Night - 2024
Status: Community picks
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FaberVitale