From e3e6f07879d7af32a47dd292a553c813b3ff318e Mon Sep 17 00:00:00 2001 From: aderijck Date: Wed, 29 Nov 2023 09:42:47 +0100 Subject: [PATCH] LS-39764 - [#LS-39764] Resolve qooxdoo 7.5 compile and runtime warnings Solves warning: Native.js:56 032572 : The method 'qx.html.Node.prototype._applyProperty()' is deprecated: The method '_applyProperty' is deprecated. Please use `registerProperty` instead (property 'repeat' in qx.html.Image) a fix on issue: LWEB-183-enable-image-to-be-set-through-theme --- source/class/qx/html/Image.js | 20 +++++++++++++++++--- source/class/qx/ui/basic/Image.js | 4 ++-- 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/source/class/qx/html/Image.js b/source/class/qx/html/Image.js index 121d96bd69c..e9b7fb88e07 100644 --- a/source/class/qx/html/Image.js +++ b/source/class/qx/html/Image.js @@ -39,6 +39,7 @@ qx.Class.define("qx.html.Image", { ); this.registerProperty("scale", null, this._setScaleProperty); + this.registerProperty("repeat", null, this._setRepeatProperty); //LS-39764 - Resolve qooxdoo 7.5 compile and runtime warnings }, /* @@ -109,7 +110,7 @@ qx.Class.define("qx.html.Image", { var source = this._getProperty("source"); var scale = this._getProperty("scale"); - var repeat = scale ? "scale" : this._getProperty("repeat") || "no-repeat"; //LWEB-183-enable-image-to-be-set-through-theme + var repeat = scale ? "scale" : this.getRepeat() || "no-repeat"; //LWEB-183-enable-image-to-be-set-through-theme //LS-39764 - Resolve qooxdoo 7.5 compile and runtime warnings // Source can be null in certain circumstances. // See bug #3701 for details. @@ -149,7 +150,7 @@ qx.Class.define("qx.html.Image", { // overridden _createDomElement() { var scale = this._getProperty("scale"); - var repeat = scale ? "scale" : this._getProperty("repeat") || "no-repeat"; //LWEB-183-enable-image-to-be-set-through-theme + var repeat = scale ? "scale" : this.getRepeat() || "no-repeat"; //LWEB-183-enable-image-to-be-set-through-theme //LS-39764 - Resolve qooxdoo 7.5 compile and runtime warnings if (qx.core.Environment.get("engine.name") == "mshtml") { var source = this._getProperty("source"); @@ -220,7 +221,7 @@ qx.Class.define("qx.html.Image", { * Whether the image should be scaled or not. * * @param value {Boolean} Scale the image - * @return {qx.html.Label} This instance for for chaining support. + * @return {qx.html.Label} This instance for chaining support. */ setScale(value) { this._setProperty("scale", value); @@ -234,6 +235,19 @@ qx.Class.define("qx.html.Image", { */ getScale() { return this._getProperty("scale"); + }, + + setRepeat(value) { //LS-39764 - Resolve qooxdoo 7.5 compile and runtime warnings + this._setProperty("repeat", value); + return this; + }, + + getRepeat() { //LS-39764 - Resolve qooxdoo 7.5 compile and runtime warnings + return this._getProperty("repeat"); + }, + + _setRepeatProperty(value) { //LS-39764 - Resolve qooxdoo 7.5 compile and runtime warnings + // Nothing } } }); diff --git a/source/class/qx/ui/basic/Image.js b/source/class/qx/ui/basic/Image.js index 3402ad16472..9e2b8b3e684 100644 --- a/source/class/qx/ui/basic/Image.js +++ b/source/class/qx/ui/basic/Image.js @@ -341,7 +341,7 @@ qx.Class.define("qx.ui.basic.Image", { _applyScale(value) { //LWEB-183-enable-image-to-be-set-through-theme if(this.getSource()) { - this._styleSource(); + this._styleSource(); } }, @@ -548,7 +548,7 @@ qx.Class.define("qx.ui.basic.Image", { this.__loadUnmanagedImage(contentEl, source); } if(!this.getScale()) { //LWEB-183-enable-image-to-be-set-through-theme - contentEl._setProperty("repeat", this.getRepeat()); + contentEl.setRepeat(this.getRepeat()); //LS-39764 - Resolve qooxdoo 7.5 compile and runtime warnings } },