patch(styles): Patching missing styles for live, adding in more style coverage #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 25, 2023 14:47
|
Looking so much better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes styling changes to the Astro plugin to more generically target elements of the Astro Panel and the Grafana UI that were overwritten when Grafana switched over to auto-generated and semi auto-generated classnames.
To achieve this, the targeting was changed, where possible, to look for pieces of classnames instead of specific classnames.
Instead of
.panel-container, we are now targeting with[class*="panel-container"]As many specific classnames were used as was possible, however this PR includes elements that are targeted with the auto-generated names. This will likely mean that these changes will need to be updated for future builds. Most of these auto-generated classnames that are now being targeted are looking at general Grafana UI, to make it look more Astro-ified, not the Astro panel itself.
This PR also includes an attempt at organizing and commenting the styles for ease of updating.