Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] added checks to urls while creating new app #63

Closed
wants to merge 1 commit into from
Closed

[FIX] added checks to urls while creating new app #63

wants to merge 1 commit into from

Conversation

ashwaniYDV
Copy link

@ashwaniYDV ashwaniYDV commented Mar 8, 2020 •
edited
Loading

closes #62

After changes:

12

@ashwaniYDV
Copy link
Author

@lolimay Please review

@shiqimei
Copy link
Contributor

shiqimei commented Jun 8, 2020

Hi @ashwaniYDV . I am not sure that we really need such field checkers. @graywolf336 @d-gubert What do you think?

@graywolf336
Copy link
Contributor

Thank you for this pull request, however, after thinking about it and reviewing it adds more potential for breakage. We will add this as a check internally whenever we are reviewing Apps.

@graywolf336 graywolf336 closed this Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] No checks for url or email
3 participants
@ashwaniYDV @shiqimei @graywolf336