Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore node_modules when linting #3

Open
mrsimpson opened this issue Sep 18, 2017 · 3 comments
Open

Ignore node_modules when linting #3

mrsimpson opened this issue Sep 18, 2017 · 3 comments

Comments

@mrsimpson
Copy link
Contributor

When re-using a node module, one does not have control over the packages while implementing the Rocketlet.
The dev-environment refusing the build due to linting errors, particularly in dependencies is not satisfying.

[09:53:41] 'lint-no-exit-ts' errored after 3.77 s
[09:53:41] Error in plugin 'gulp-tslint'
Message:
  /.../temporary-rocketlets-dev-environment/rocketlets/smarti/node_modules/http-status-enum/src/index.ts [43, 35]: Missing trailing comma.

@graywolf336
Copy link
Contributor

Ah, so your folder structure is:

dev-env
  -> rocketlets
     -> smarti (which is a git repository)
        -> node_modules

Okay, so the rocketlets/**/node_modules needs to be ignored 👍

@mrsimpson
Copy link
Contributor Author

Exactly. That's how I thought you intended a dev environment to be used.
Any other ideas, how it should be consumed?

Additionally, it was nice it the .gitignore ignored all the Rocketlets - except the samples. Don't know whether such expressions are supported though

@graywolf336
Copy link
Contributor

Yeah it is, I just wanted to confirm it.

Yes, I am going to see about that as I think it is possible. 👍

Shailesh351 added a commit to Shailesh351/Rocket.Chat.Apps-cli that referenced this issue Mar 30, 2021
[Upstream Catchup] Merge Rocket.Chat.Apps-cli:master to master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants