From 3317512260ef2585753127cbae11d07672a92ee8 Mon Sep 17 00:00:00 2001 From: Zishan Ahmad Date: Sun, 22 Dec 2024 15:50:52 +0530 Subject: [PATCH] =?UTF-8?q?Revert=20"Added=20a=20validation=20check=20for?= =?UTF-8?q?=20pr=20approval=20in=20the=20deploy-pr=20workflow=20(#?= =?UTF-8?q?=E2=80=A6"?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit f0d28488689dcc2ab8172caef17f5d1f8b1e9d11. --- .github/workflows/build-pr.yml | 11 +------ .github/workflows/deploy-pr.yml | 58 +++------------------------------ 2 files changed, 5 insertions(+), 64 deletions(-) diff --git a/.github/workflows/build-pr.yml b/.github/workflows/build-pr.yml index 940999222..66c97af32 100644 --- a/.github/workflows/build-pr.yml +++ b/.github/workflows/build-pr.yml @@ -12,7 +12,7 @@ env: LAYOUT_EDITOR_BASE_URL: "/EmbeddedChat/pulls/pr-${{github.event.pull_request.number}}/layout_editor" DOCS_BASE_URL: "/EmbeddedChat/pulls/pr-${{github.event.pull_request.number}}/docs" STORYBOOK_RC_HOST: "https://demo.qa.rocket.chat" - + jobs: build: if: github.event.review.state == 'approved' && (github.event.review.author_association == 'COLLABORATOR' || github.event.review.author_association == 'OWNER') @@ -22,15 +22,6 @@ jobs: - name: Checkout code uses: actions/checkout@v2 - - name: Get user - run: echo "${{ github.event.pull_request.head.repo.owner.login }}" > user.txt - - - name: Upload Artifacts - uses: actions/upload-artifact@v4 - with: - name: user - path: user.txt - - name: Setup Node.js uses: actions/setup-node@v4 with: diff --git a/.github/workflows/deploy-pr.yml b/.github/workflows/deploy-pr.yml index c999c5173..4f687507d 100644 --- a/.github/workflows/deploy-pr.yml +++ b/.github/workflows/deploy-pr.yml @@ -1,71 +1,22 @@ name: Deploy PR-Preview + on: workflow_run: workflows: ["Build PR-Preview"] types: - completed + permissions: contents: write pages: write + jobs: deploy: if: github.event.workflow_run.conclusion == 'success' runs-on: ubuntu-latest - steps: - - uses: actions/download-artifact@v4 - with: - name: user - path: . - github-token: ${{github.token}} - repository: ${{github.repository}} - run-id: ${{github.event.workflow_run.id}} - - - name: Get user - id: get_user - run: | - USER=$(cat user.txt) - echo "USER=$USER" >> $GITHUB_ENV - - - name: Get Pull Request Number - id: get_pr_number - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - run: | - PR_NUMBER=$(curl -s -H "Authorization: token $GITHUB_TOKEN" \ - "https://api.github.com/repos/${{ github.repository }}/pulls?head=${{env.USER}}:${{ github.event.workflow_run.head_branch }}" \ - | jq -r '.[0].number') - echo "PR_NUMBER=$PR_NUMBER" >> $GITHUB_ENV - - - name: Check PR Approval Status - id: approval_check - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - run: | - PR_NUMBER=${{ env.PR_NUMBER }} - - RESPONSE=$(curl -s -H "Authorization: token $GITHUB_TOKEN" \ - "https://api.github.com/repos/${{ github.repository }}/pulls/$PR_NUMBER/reviews") - - if ! echo "$RESPONSE" | jq . > /dev/null 2>&1; then - echo "Error: Invalid JSON response from GitHub API." - exit 1 - fi - - LATEST_REVIEW=$(echo "$RESPONSE" | jq 'sort_by(.submitted_at) | last') - - STATE=$(echo "$LATEST_REVIEW" | jq -r '.state') - AUTHOR_ASSOCIATION=$(echo "$LATEST_REVIEW" | jq -r '.author_association') - - echo "Latest review state: $STATE" - echo "Author association: $AUTHOR_ASSOCIATION" - - if [ "$STATE" != "APPROVED" ] || { [ "$AUTHOR_ASSOCIATION" != "COLLABORATOR" ] && [ "$AUTHOR_ASSOCIATION" != "OWNER" ]; }; then - echo "The latest review is not an approved review from a collaborator or owner. Exiting." - exit 1 - fi + steps: - uses: actions/download-artifact@v4 - if: success() with: name: github-pages path: build/ @@ -74,7 +25,6 @@ jobs: run-id: ${{github.event.workflow_run.id}} - name: Deploy to GitHub Pages - if: success() uses: crazy-max/ghaction-github-pages@v2 with: target_branch: gh-deploy