We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Description When the Marker object calls the update function, the THREE.Mesh instance(color meterial) memory is not released.
Steps To Reproduce
... case ROS3D.MARKER_TEXT_VIEW_FACING: this.traverse (function (child){ if (child instanceof THREE.Mesh) { child.material = colorMaterial; } }); break; case ROS3D.MARKER_MESH_RESOURCE: var meshColorMaterial = null; if(message.color.r !== 0 || message.color.g !== 0 || message.color.b !== 0 || message.color.a !== 0) { meshColorMaterial = this.colorMaterial; } this.traverse (function (child){ if (child instanceof THREE.Mesh) { child.material = meshColorMaterial; } }); break; ...
Expected Behavior Open Chrome developer tool and click Memory tag, memory stable
Actual Behavior Memory is growing
Quick fix
... case ROS3D.MARKER_TEXT_VIEW_FACING: this.traverse (function (child){ if (child instanceof THREE.Mesh) { child.material.dispose(); child.material = colorMaterial; } }); break; case ROS3D.MARKER_MESH_RESOURCE: var meshColorMaterial = null; if(message.color.r !== 0 || message.color.g !== 0 || message.color.b !== 0 || message.color.a !== 0) { meshColorMaterial = this.colorMaterial; } this.traverse (function (child){ if (child instanceof THREE.Mesh) { if (child.material !== null) { child.material.dispose(); } child.material = meshColorMaterial; } }); break; ...
The text was updated successfully, but these errors were encountered:
@Naxior I am not able to test it right now. But could you create a PR in the meantime? You found the bug, so it is better, when you write the commit.
Sorry, something went wrong.
No branches or pull requests
Description
When the Marker object calls the update function, the THREE.Mesh instance(color meterial) memory is not released.
Steps To Reproduce
Expected Behavior
Open Chrome developer tool and click Memory tag, memory stable
Actual Behavior
Memory is growing
Quick fix
The text was updated successfully, but these errors were encountered: