[doc] Add "Alternatives" for Bazel and ROS 2 workflows; mention ApexAI/rules_ros and mvukov/rules_ros2 #194
Conversation
Add note about ament index propagation Demote sections under ./ros2 Bazel details
There was a problem hiding this comment.
+@sloretz for review, please!
\cc @cottsay
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @sloretz)
|
Here is a yet another alternative https://github.com/mvukov/rules_ros2/ ;). |
There was a problem hiding this comment.
Done, thanks! I've tried to add in a summary here. If you have a chance, could you take a look to see if it's fair / accurate?
And it cool if I file issue against your repo for similar? If you wanna link here, or add your own analysis, I'm good either way!
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @sloretz)
Sure, you can either open an issue or make a PR. |
There was a problem hiding this comment.
Aye, I'll make a quick PR.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @sloretz)
bazel_ros2_rules/ros2/README.md line 144 at r2 (raw file):
Previously, mvukov (Milan Vukov) wrote…
Nit: packages.
Done 0ef58e9, thanks!
|
@EricCousineau-TRI This looks good to me. Thanks for referencing the ApexAI/rules_ros here. |
|
Awesome, thank you for checking! |
EricCousineau-TRI
changed the title
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @EricCousineau-TRI)
bazel_ros2_rules/ros2/README.md line 186 at r3 (raw file):
- Writing Python bindings in `pybind11` against other C++ libraries that have their own bindings - e.g., [Drake](https://drake.mit.edu/). - There is *some* affordance for leveraging `pybind11` against ROS 2 RMW
I don't see anything pybind11 specific in bazel_ros2_rules. Is this actually a feature of this approach? I know we use pybind11 in drake_ros_* but that seems unrelated to the generated bazel rules.
grep bazel_ros2_rules/ -r -e "pybind"
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @sloretz)
bazel_ros2_rules/ros2/README.md line 186 at r3 (raw file):
Previously, sloretz (Shane Loretz) wrote…
I don't see anything pybind11 specific in
bazel_ros2_rules. Is this actually a feature of this approach? I know we use pybind11 indrake_ros_*but that seems unrelated to the generated bazel rules.grep bazel_ros2_rules/ -r -e "pybind"
Done. You're right! But I still want to emphasize the examples portion, so I've rescoped this statement as such.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @EricCousineau-TRI)
|
Thanks! |
Per internal discussion.
Filed issue for RFC and possible symmetry:
drake-ros/bazel_ros2_rules? ApexAI/rules_ros#5This change is