Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vue-popper wraps components in span, while this is not always desirable #87

Open
andriy-f opened this issue Mar 13, 2019 · 3 comments
Open

Comments

@andriy-f
Copy link

vue-popper wraps components in span, while this is not always desirable

It's not ok if child elements are div. Div is block element, span is inline, div's can't be inside spans
Maybe make wrapper type configurable?

@alfonsobries
Copy link
Contributor

This PR adds this option #94

@kevintruby
Copy link

I think this is still an open issue, actually. Looked at the PR that @alfonsobries provided, which is one step to solving the problem, but that only provides a way of overriding one of two possible <span>s.

There's still a hard-coded <span> wrapping the default slot. My guess is this is likely due to use of the v-show directive.

If a v-if directive were used, you could substitute a <template> tag instead, but then it has to be re-rendered every time the display is affected.

I'll try to tinker around a bit, but I don't see any reason why we couldn't also use the <component :is="tagName"> in place of the remaining hard-coded <span> tag.

@RobinCK
Copy link
Owner

RobinCK commented Sep 6, 2019

this good idea, welcome to pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants