Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor internal query builder to use the JSON protocol #707

Open
RobertCraigie opened this issue Feb 26, 2023 · 3 comments · May be fixed by #1035
Open

Refactor internal query builder to use the JSON protocol #707

RobertCraigie opened this issue Feb 26, 2023 · 3 comments · May be fixed by #1035
Labels
kind/improvement An improvement to existing feature and code. level/advanced priority/medium topic: internal Improvement or addition to non user facing code

Comments

@RobertCraigie
Copy link
Owner

RobertCraigie commented Feb 26, 2023 •
edited
Loading

Prisma are working on removing the internal GraphQL protocol and moving to a JSON-based approach instead which will simplify a lot of internal code and potentially result in the ability to completely remove certain codegen-metadata resulting in smaller package sizes in applications where that matters.

This would also remove the requirement to wrap json values in Json(...)!

Public proposal
@RobertCraigie RobertCraigie added kind/improvement An improvement to existing feature and code. topic: internal Improvement or addition to non user facing code level/advanced priority/medium labels Feb 26, 2023
@ProgramRipper
Copy link

Sorry for commenting on this old issue.
I am curious if the JSON protocol is still on the plan? As Prisma 5 released and JSON protocol became the default protocol.

@RobertCraigie
Copy link
Owner Author

Yes the JSON protocol will be incorporated at some point in the future, here's the WIP PR if you're interested.

ProgramRipper added a commit to ProgramRipper/prisma-client-py that referenced this issue Sep 28, 2024
@ProgramRipper
feat(engine): json protocol
e0098d4 
closed RobertCraigie#707, RobertCraigie#748
@ProgramRipper ProgramRipper linked a pull request Sep 28, 2024 that will close this issue
Open
4 tasks
@ProgramRipper
Copy link

ProgramRipper commented Sep 28, 2024 •
edited
Loading

I make a naive implementation in #1035, and pass existing tests (except test_field_not_found_error_selection) now. Although I don't understand much about Prisma and this project, I hope this can help. 😉

@steebchen steebchen mentioned this issue Nov 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/improvement An improvement to existing feature and code. level/advanced priority/medium topic: internal Improvement or addition to non user facing code
Projects
Prisma Client Python
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(engine): json protocol ProgramRipper/prisma-client-py
2 participants
@RobertCraigie @ProgramRipper