Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0003-Panda-expansion-add-spidev.patch remarks #30

Open
ywanwanscappel opened this issue Jun 5, 2013 · 3 comments
Open

0003-Panda-expansion-add-spidev.patch remarks #30

ywanwanscappel opened this issue Jun 5, 2013 · 3 comments

Comments

@ywanwanscappel
Copy link

Hello,

Playing with SPI on my pandaboard ES card, I noticed the following things:

The trace "enabling spi3/spi4" is misleading.
The patch enables spidev for SPI1, chipselect 0 and 1, not spi3 and spi4.

The corresponding pins are not configured automatically.

Looking into the similar patch for omap beagle expansion, when registering the spidev driver, the corresponding pin mux configuration is also performed. Maybe it could be a good thing to add this configuration to the Panda patch.

Best regards,
Yann

@RobertCNelson
Copy link
Owner

Hi Yann,

That would be a great patch for the panda's last horrah as mainline board file based kernel image (v3.10.x).. Got a patch ready? As with v3.11.x the board-omap4panda.c is slated to be deleted and we will have to figure out a device tree "buddy=spidev" replacement.

Regards

@aferre
Copy link

aferre commented Jun 5, 2013

Sorry about the misleading commentary.

Robert, why is the panda file deleted? Is th

Le 5 juin 2013 à 18:46, Robert Nelson a écrit :

Hi Yann,

That would be a great patch for the panda's last horrah as mainline board file based kernel image (v3.10.x).. Got a patch ready? As with v3.11.x the board-omap4panda.c is slated to be deleted and we will have to figure out a device tree "buddy=spidev" replacement.

Regards


Reply to this email directly or view it on GitHub.

@RobertCNelson
Copy link
Owner

The removal hass been "announced" by tony, our omap maintainer...
http://www.mail-archive.com/[email protected]/msg89188.html

"Device Tree's" are the future, and as the such when the *.dtb are close in functionality the boards are usually removed.. (For example, the imx guys removed all their imx5x board files in v3.5-rc when the *.dtb was equal in functionality..)

Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants