Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Before Time Equal to Current Time Fails Authorization #19

Open
GHDevelop opened this issue May 10, 2022 · 0 comments
Open

Not Before Time Equal to Current Time Fails Authorization #19

GHDevelop opened this issue May 10, 2022 · 0 comments

Comments

@GHDevelop
Copy link

Currently, in src/Validation/Validate.php at method "notBefore" the comparison done between $notBefore and time() is <. If $notBefore and time() are identical (and time() is only precise to the second), then authorization will fail even though the token isn't being used before the not before time. I'm open to correction, but I get the impression that using <= instead would be appropriate, since there are cases where developers would generate a token (with not before time and issued at time set to the same value) and then quickly use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant