Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown broken in v2 ... #6

Open
DivadNojnarg opened this issue Oct 17, 2023 · 7 comments
Open

Dropdown broken in v2 ... #6

DivadNojnarg opened this issue Oct 17, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@DivadNojnarg
Copy link
Member

DivadNojnarg commented Oct 17, 2023

See nextui-org/nextui#1809

@DivadNojnarg DivadNojnarg added the bug Something isn't working label Oct 17, 2023
@DivadNojnarg DivadNojnarg changed the title Dropdown and popover broken in v2 ... Dropdown broken in v2 ... Nov 5, 2023
@DivadNojnarg
Copy link
Member Author

TO DO: try out with the reactR approach ...

@DivadNojnarg
Copy link
Member Author

Kind of working, except that reactR does not easily allow to pass shiny tags as children (jsonlite can't serialize shiny tags).

timelyportfolio added a commit to timelyportfolio/shinyNextUI that referenced this issue Nov 29, 2023
timelyportfolio added a commit to timelyportfolio/shinyNextUI that referenced this issue Nov 29, 2023
@timelyportfolio
Copy link

timelyportfolio commented Nov 29, 2023

I pushed two commits in my fork to potentially get closer to a working <Dropdown> with startContent defined from R. I ran out of time, but I think all that is left would be to convert the tag object with React.createElement before https://github.com/RinteRface/shinyNextUI/blob/main/js/src/custom.js#L59 and https://github.com/RinteRface/shinyNextUI/blob/main/js/src/custom.js#L75.

@timelyportfolio
Copy link

@DivadNojnarg This is working now with icon in main branch of fork. If we expected nested tags, then we could look at using hydrate from react-R.

timelyportfolio added a commit to timelyportfolio/shinyNextUI that referenced this issue Dec 1, 2023
@DivadNojnarg
Copy link
Member Author

Working well on my side. Yes the plan would be to be able to pass any nested set of tags in any component (not just dropdown).
Screenshot 2023-12-01 at 08 59 16

@timelyportfolio
Copy link

@DivadNojnarg With the partial solution presented entirely handled in shinyNextUI, I wonder if there are things we can do in reactR to offer a more universal solution. It seems react-R/reactR#67 is closely related. Would it be ok if we continue the discussion there?

Let me know how I can help on shinyNextUI specifically. Thanks for all your great work.

@DivadNojnarg
Copy link
Member Author

@timelyportfolio. Yes sorry. This is what I initially meant, if reactR could support this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants