This repository has been archived by the owner on Jul 25, 2024. It is now read-only.
Sourcery refactored master branch #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| byte = (value >> (shift * 8)) & 0xff | ||
| return byte | ||
| return (value >> (shift * 8)) & 0xff |
There was a problem hiding this comment.
Function u64_get_byte refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-96
to
+95
| hollywood = decodeWiiID(nwc24_id)[3] | ||
| return hollywood | ||
| return decodeWiiID(nwc24_id)[3] |
There was a problem hiding this comment.
Function NWC24GetHollywoodID refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-100
to
+98
| id_ctr = decodeWiiID(nwc24_id)[4] | ||
| return id_ctr | ||
| return decodeWiiID(nwc24_id)[4] |
There was a problem hiding this comment.
Function NWC24GetIDCounter refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-104
to
+101
| hardware_model = decodeWiiID(nwc24_id)[1] | ||
| return hardware_model | ||
| return decodeWiiID(nwc24_id)[1] |
There was a problem hiding this comment.
Function NWC24GetHardwareModel refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
103
to
104
| area_code = decodeWiiID(nwc24_id)[2] | ||
| return area_code No newline at end of file | ||
| return decodeWiiID(nwc24_id)[2] |
There was a problem hiding this comment.
Function NWC24GetAreaCode refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!