Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logLevel an instance variable instead of static #173

Open
armcknight opened this issue Nov 4, 2019 · 4 comments · May be fixed by #180
Open

Make logLevel an instance variable instead of static #173

armcknight opened this issue Nov 4, 2019 · 4 comments · May be fixed by #180

Comments

@armcknight
Copy link
Contributor

We use this in an app with two different types of loggers, A and B which inherits from A. We are not able to set their log levels independently because the log level is statically defined on the class Log. If it were instance-level, then this connection would be broken and loggers would behave as expected when setting them to different levels.

@ZevEisenberg
Copy link
Collaborator

+1 or at least have a global for general-purpose static logging, but let you override it if you want to instantiate loggers other than the default/shared logger. Progressive disclosure.

@chrisballinger
Copy link
Contributor

We just got bit by this again today.

@chrisballinger
Copy link
Contributor

If we're keeping score, someone else got bit by this again today.

@ZevEisenberg
Copy link
Collaborator

Doooo eeeeet

@jmagnini jmagnini linked a pull request May 26, 2021 that will close this issue
@jmagnini jmagnini linked a pull request May 26, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants