Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL not work with Eclair 0.9.0 #1277

Closed
xbukorg opened this issue Aug 22, 2023 · 2 comments · Fixed by #1293
Closed

RTL not work with Eclair 0.9.0 #1277

xbukorg opened this issue Aug 22, 2023 · 2 comments · Fixed by #1293
Assignees
@ShahanaFarooqui
Labels
Eclair P1 High priority issue
Milestone
Release 0.14.1-beta

Comments

@xbukorg
Copy link

xbukorg commented Aug 22, 2023

RTL not work with Eclair 0.9.0 because breaking API change in Eclair code

See attached picture and logfile.

new 1.txt
RTL
@xbukorg
Copy link
Author

xbukorg commented Aug 22, 2023

The fix below solved problem only partially I am thinking.
When I open more channels parallelly I get still empty list.
Please test fix before release new version of RTL.

@ShahanaFarooqui ShahanaFarooqui self-assigned this Aug 22, 2023
@ShahanaFarooqui ShahanaFarooqui added this to the Release 0.14.1-beta milestone Aug 22, 2023
@ShahanaFarooqui ShahanaFarooqui added the P1 High priority issue label Aug 22, 2023
@mercurytoxic mercurytoxic mentioned this issue Aug 23, 2023
Closed
@ShahanaFarooqui ShahanaFarooqui linked a pull request Sep 29, 2023 that will close this issue
Updated channels response columns and migrated pagesettings #1293
Merged
@ShahanaFarooqui
Copy link
Collaborator

PR #1293 fixes the issue where Eclair 0.9.0 changed their channel list response. However, the change is not backward compatible. Only upgrade to RTL v0.14.1 if Eclair is on >=v0.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShahanaFarooqui ShahanaFarooqui

Labels
Eclair P1 High priority issue
Projects
None yet
Milestone
Release 0.14.1-beta
Development

Successfully merging a pull request may close this issue.

Updated channels response columns and migrated pagesettings Ride-The-Lightning/RTL
2 participants
@ShahanaFarooqui @xbukorg