Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor event getting / approval getting code to be more generic #231

Closed
rkalis opened this issue Aug 28, 2024 · 1 comment
Closed

Refactor event getting / approval getting code to be more generic #231

rkalis opened this issue Aug 28, 2024 · 1 comment
Assignees
@Steen3S

Comments

@rkalis
Copy link
Member

rkalis commented Aug 28, 2024

Right now, we retrieve a bunch of events with different formats, that we read from in our different approvalToAllowance functions. Ideally we'd add an intermediate data structure that normalises the underlying raw blockchain data into an abstract ApprovalEvent (or more generic TokenEvent to also include transfers). This should make it easier to ad support for other chains that work slightly different from most EVM chains (such as LUKSO or Starknet).
@rkalis
Copy link
Member Author

rkalis commented Nov 29, 2024

We refactored the events to be more generic. No work has been done yet to build on top of that to support other chains like LUKSO.

@rkalis rkalis closed this as completed Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Steen3S Steen3S

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

231-refactor-event-getting-approval-getting-code-to-be-more-generic RevokeCash/revoke.cash
2 participants
@rkalis @Steen3S