Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LUKSO with LSP7/8 tokens #206

Open
rkalis opened this issue Mar 25, 2024 · 0 comments
Open

Support LUKSO with LSP7/8 tokens #206

rkalis opened this issue Mar 25, 2024 · 0 comments

Comments

@rkalis
Copy link
Member

rkalis commented Mar 25, 2024

LUKSO is an EVM compatible network, so it can be integrated like other networks. However, they've developed separate token standards called LSP7 (their ERC20) and LSP8 (their ERC721).

The LSP7 token standard doesn't really solve any of the problems associated with token approvals, although the LSP8 standard does improve some of the security issues with ERC721 token approvals.

Despite this, these tokens standards do change all of the interfaces / names compared to their Ethereum counterparts for some reason (e.g. OperatorAuthorizationChanged instead of Approval events are emitted and authorizedAmountFor is called instead of allowance to get the current token approval value).

This makes integrating existing Ethereum applications (including Revoke.cash) with these tokens a huge pain (again, without a lot of gain). It should be possible to create an special case for LUKSO's token standards in the future, but for now I don't see this being worth the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant