-
-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newer version of vue and pdfjs is not detected by retirejs #458
Comments
Please be more specific. Which versions did you test with? |
Retire version: 4.3.1 |
Are these minified in some way? Can you share a link to the file? Detection works for all versions of pdf.js in the testcases in https://github.com/RetireJS/retire.js/blob/master/repository/testcases.json#L638 |
It does detect that version from the CDNs. But I'm still wondering where you found this problem to begin with. What were you scanning? |
The |
I was scanning a war file. Earlier it had pdf.js file, so version of same was detectable. After pdfjs upgrade files changed to mjs which was not detected. |
Ok, then you should be able to use the --ext option, but maybe we need to make mjs,js the default... |
Will add this fix to retire v4.4.4 as well, allthough it's proably be better to be on v5 |
Try version 4.4.4 with |
pdf.js file is getting detected. |
Can you share the vue.min.js file here? |
@rashmimehta300 Can you share the vue.min.js file here? We have tests for 3.4.27, so not sure why it's not detecting it. |
Retire.js version: 4.3.1
node version: 18.3.1
Description: Newer version of vuejs(3.x) and is not detected.
Expected behaviour: Retire js should detect newer version of vuejs and pdfjs
If this is a false positive or false negative: False negative
The text was updated successfully, but these errors were encountered: