From cd9b764ab7da4e8cac1a7c204e6cd822b40ddf9d Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Thu, 23 May 2024 16:23:48 -0400 Subject: [PATCH 1/2] Refer to containers/ subfolder and the correct path in example There is no ~/top-level-dataset/ Even though we should migrate to use code/containers, current example does not so copy pasting individual commands does not work. The monolythic script is ok --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index c21cdf5a..79199712 100644 --- a/README.md +++ b/README.md @@ -238,15 +238,15 @@ dataset, **or** the top-level dataset. **Option 1: Top level dataset (recommended)** ```bash -# Run from ~/top-level-dataset +# Run from ~/my-experiments/ds000003-qc datalad run -m "Downgrade/Freeze mriqc container version" \ - code/containers/scripts/freeze_versions --save-dataset=. bids-mriqc=0.16.0 + containers/scripts/freeze_versions --save-dataset=. bids-mriqc=0.16.0 ``` **Option 2: ///repronim/containers** ```bash -# Run from ~/top-level-dataset/code/containers +# Run from ~/my-experiments/ds000003-qc/containers datalad run -m "Downgrade/Freeze mriqc container version" \ scripts/freeze_versions bids-mriqc=0.16.0 ``` From 67aa0d3cd1c9deba9f0902a087bdcdcd4c29a279 Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Fri, 24 May 2024 08:31:23 -0400 Subject: [PATCH 2/2] Show full array Interestingly it does not fail shellcheck locally but does on CI --- scripts/replace_neurodesk_urls | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/replace_neurodesk_urls b/scripts/replace_neurodesk_urls index 2391ddac..fa70656f 100755 --- a/scripts/replace_neurodesk_urls +++ b/scripts/replace_neurodesk_urls @@ -39,7 +39,7 @@ for f in images/neurodesk/*.simg ; do else echo "OK: $newurl" >&2 if [ -n "${cloudfronturls[*]}" ]; then - echo " INFO: cloudfront url seems to be already known -- $cloudfronturls . Not adding" + echo " INFO: cloudfront url seems to be already known -- ${cloudfronturls[*]} . Not adding" else echo " INFO: adding $newurl to $f" git -c annex.alwayscommit=false annex addurl "--file=$f" "$newurl"