Skip to content
This repository has been archived by the owner on Apr 8, 2022. It is now read-only.

When allowing an item that already exists to be imported with importOnDuplicate rollbacks will try to delete #29

Open
bmiller08 opened this issue Jan 6, 2022 · 3 comments

Comments

@bmiller08
Copy link
Contributor

Describe the bug
When utilizing importOnDuplicate to import items that already exist.. if the import is successful and something else in the stack fails and the stack rolls back it will try to delete the imported resource. This will inevitably lead to a lot of other errors.

To Reproduce
Steps to reproduce the behavior:

  1. Create an OU manually
  2. Add it to the stack with import on duplicate
  3. Create another OU manually
  4. Add it to the stack after the first OU and dont allow imports on duplicate
  5. Deploy the stack. The first OU will import, the second will fail as expected, and the first one will be deleted.

Expected behavior
If importOnDuplicate is used and the stack is rolling back then delete should retain the item. Perhaps the python code could check the stack state before a delete.

Screenshots

Logs

Additional context

@bmiller08
Copy link
Contributor Author

Low priority for now. If an OU is deleted its not a big deal. Accounts cant be deleted. The primary annoyance is broken rollback states.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

This issue is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon.

@github-actions github-actions bot added the stale label Mar 8, 2022
@bmiller08
Copy link
Contributor Author

bump

@github-actions github-actions bot removed the stale label Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant