Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shows display incorrect venue names #45

Open
lukeswitz opened this issue Aug 10, 2019 · 3 comments
Open

Shows display incorrect venue names #45

lukeswitz opened this issue Aug 10, 2019 · 3 comments

Comments

@lukeswitz
Copy link

Examples: Disco Biscuits @ Revolution in 2006-03-10 gets the metadata from the show in St Pete instead of downtown Ft. Lauderdale where I set up the mics. Others include NYE 2006-12-31 which was at the tweeter center, and incorrectly says it was at the E factory in Philly.

This is not limited to the artist, other tapes of mine are not reflecting archive.org metadata. We should work together in ensuring what you pull from there is correct and in sync with etree.org and archive.org.

This is my first visit to the repo, I look forward to moving the posts forward with you on the iOS version. If you tag some issue with help-wanted I can move through them with priority. Cheers!

@lukeswitz
Copy link
Author

Found this to be a problem affecting many shows, entire tour sections such as the above: all shows in October of 2002 seem to be off by a day in their venue & location. 'View on archive' displays the correct data, seems an issue with the Relisten.weasly API

@lukeswitz
Copy link
Author

@farktronix farktronix transferred this issue from RelistenNet/relisten-ios Oct 26, 2020
@switz
Copy link
Member

switz commented Oct 26, 2020

https://github.com/RelistenNet/RelistenApi/blob/master/RelistenApi/Services/Importers/ArchiveOrgImporter.cs#L270

I believe this happens due to the importer only using the venue name as it's unique id. It's merely a bug, that should be fixable by extending the venue id to support the venue city as well. I am a bit worried that not every archive source will properly tag the city name and we may end up with several venue entities created for what should be a single venue, but there's no perfect solution here. This is just the nature of dealing with unstructured, user inputted data.

We should add the city name to the id though, which would ostensibly fix this issue. If anyone wants to run with it and work on this, let me know and we can rescrape Archive after it's implemented and deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants