Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default value as object in request body #2437

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix: default value as object in request body #2437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/Fields/FieldDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@ export const FieldDetailsComponent = observer((props: FieldProps) => {

return null;
}, [field, showExamples]);

const defaultValue = isObject(schema.default)
? getSerializedValue(field, schema.default).replace(`${field.name}=`, '')
: schema.default;
const defaultValue =
isObject(schema.default) && field.in
? getSerializedValue(field, schema.default).replace(`${field.name}=`, '')
: schema.default;

return (
<div>
Expand Down
32 changes: 32 additions & 0 deletions src/components/__tests__/FieldDetails.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,36 @@ describe('FieldDetailsComponent', () => {

expect(wrapper.render()).toMatchSnapshot();
});

it('renders correctly when default value is object in request body', () => {
const mockFieldProps = {
showExamples: true,
field: {
schema: {
type: 'object',
default: { properties: {} },
displayType: 'object',
title: 'test title',
externalDocs: undefined,
constraints: [''],
} as SchemaModel,
example: 'example',
name: 'name',
expanded: false,
required: false,
kind: '',
deprecated: false,
collapse: jest.fn(),
toggle: jest.fn(),
explode: false,
expand: jest.fn(),
description: 'test description',
in: undefined,
},
renderDiscriminatorSwitch: jest.fn(),
};
const wrapper = shallow(withTheme(<FieldDetails {...mockFieldProps} />));

expect(wrapper.render()).toMatchSnapshot();
});
});
68 changes: 67 additions & 1 deletion src/components/__tests__/__snapshots__/FieldDetails.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,73 @@ exports[`FieldDetailsComponent renders correctly 1`] = `
<span
class="sc-kpDqfm sc-eldPxv cGRfjn ehWiAn"
>
""
[]
</span>
</div>

<div>
<span
class="sc-kpDqfm cGRfjn"
>
Example:
</span>

<span
class="sc-kpDqfm sc-eldPxv cGRfjn ehWiAn"
>
"example"
</span>
</div>
<div>
<div
class="sc-lcIPJg sc-hknOHE gBHqkN jFBMaE"
>
<p>
test description
</p>


</div>
</div>
</div>
`;

exports[`FieldDetailsComponent renders correctly when default value is object in request body 1`] = `
<div>
<div>
<span
class="sc-kpDqfm sc-dAlyuH cGRfjn gHomYR"
/>
<span
class="sc-kpDqfm sc-jlZhew cGRfjn dYtiIA"
>
object
</span>
<span
class="sc-kpDqfm sc-cwHptR cGRfjn gyVIPr"
>
(test title)
</span>
<span>

<span
class="sc-kpDqfm sc-gFqAkR cGRfjn fYEICH"
>

</span>
</span>
</div>
<div>
<span
class="sc-kpDqfm cGRfjn"
>
Default:
</span>

<span
class="sc-kpDqfm sc-eldPxv cGRfjn ehWiAn"
>
{"properties":{}}
</span>
</div>

Expand Down
Loading